Chromium Code Reviews
Help | Chromium Project | Sign in
(777)

Issue 5708006: Optimizing BuildResultFromMatchInfo, StringReplace and StringSplit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by sandholm
Modified:
4 years, 2 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev, Erik Corry
Visibility:
Public.

Description

Optimizing BuildResultFromMatchInfo, StringReplace and StringSplit.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 12

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -83 lines) Patch
M src/regexp.js View 1 2 3 8 chunks +31 lines, -35 lines 0 comments Download
M src/string.js View 1 2 3 13 chunks +45 lines, -48 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 5 (0 generated)
sandholm
4 years, 7 months ago (2010-12-13 08:51:31 UTC) #1
Lasse Reichstein
LGTM if you name your constants. http://codereview.chromium.org/5708006/diff/2001/src/regexp.js File src/regexp.js (right): http://codereview.chromium.org/5708006/diff/2001/src/regexp.js#newcode126 src/regexp.js:126: if (start + ...
4 years, 7 months ago (2010-12-13 09:29:12 UTC) #2
sandholm
Changed a few more bits. Please have another look. http://codereview.chromium.org/5708006/diff/2001/src/regexp.js File src/regexp.js (right): http://codereview.chromium.org/5708006/diff/2001/src/regexp.js#newcode126 src/regexp.js:126: ...
4 years, 7 months ago (2010-12-13 12:03:35 UTC) #3
Lasse Reichstein
LGTM http://codereview.chromium.org/5708006/diff/9001/src/string.js File src/string.js (right): http://codereview.chromium.org/5708006/diff/9001/src/string.js#newcode590 src/string.js:590: var num_captures_plus3 = "_plus3" might be a little ...
4 years, 7 months ago (2010-12-13 12:08:58 UTC) #4
sandholm
4 years, 7 months ago (2010-12-13 12:18:15 UTC) #5
http://codereview.chromium.org/5708006/diff/9001/src/string.js
File src/string.js (right):

http://codereview.chromium.org/5708006/diff/9001/src/string.js#newcode590
src/string.js:590: var num_captures_plus3 =
On 2010/12/13 12:08:58, Lasse Reichstein wrote:
> "_plus3" might be a little too specific.
> How about "matchinfo_length"?
> (not to be confused with matchinfo.length, which may be longer :)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f