Chromium Code Reviews
Help | Chromium Project | Sign in
(763)

Issue 5708006: Optimizing BuildResultFromMatchInfo, StringReplace and StringSplit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by sandholm
Modified:
2 years, 11 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev_googlegroups.com, Erik Corry
Visibility:
Public.

Description

Optimizing BuildResultFromMatchInfo, StringReplace and StringSplit.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 12

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -83 lines) Lint Patch
M src/regexp.js View 1 2 3 8 chunks +31 lines, -35 lines 0 comments 0 errors Download
M src/string.js View 1 2 3 13 chunks +45 lines, -48 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
sandholm
3 years, 4 months ago #1
Lasse Reichstein
LGTM if you name your constants. http://codereview.chromium.org/5708006/diff/2001/src/regexp.js File src/regexp.js (right): http://codereview.chromium.org/5708006/diff/2001/src/regexp.js#newcode126 src/regexp.js:126: if (start + ...
3 years, 4 months ago #2
sandholm
Changed a few more bits. Please have another look. http://codereview.chromium.org/5708006/diff/2001/src/regexp.js File src/regexp.js (right): http://codereview.chromium.org/5708006/diff/2001/src/regexp.js#newcode126 src/regexp.js:126: ...
3 years, 4 months ago #3
Lasse Reichstein
LGTM http://codereview.chromium.org/5708006/diff/9001/src/string.js File src/string.js (right): http://codereview.chromium.org/5708006/diff/9001/src/string.js#newcode590 src/string.js:590: var num_captures_plus3 = "_plus3" might be a little ...
3 years, 4 months ago #4
sandholm
3 years, 4 months ago #5
http://codereview.chromium.org/5708006/diff/9001/src/string.js
File src/string.js (right):

http://codereview.chromium.org/5708006/diff/9001/src/string.js#newcode590
src/string.js:590: var num_captures_plus3 =
On 2010/12/13 12:08:58, Lasse Reichstein wrote:
> "_plus3" might be a little too specific.
> How about "matchinfo_length"?
> (not to be confused with matchinfo.length, which may be longer :)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6