Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: BUILD.gn

Issue 570793002: GN & libvpx: Missing deps for generating ASM offsets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
===================================================================
--- BUILD.gn (revision 291959)
+++ BUILD.gn (working copy)
@@ -127,6 +127,10 @@
"//third_party/libvpx/source/libvpx",
target_gen_dir
]
+ deps = [
+ ":gen_asm_offsets_vp8",
+ ":gen_asm_offsets_scale",
+ ]
}
}
@@ -202,13 +206,17 @@
static_library("libvpx_assembly_arm") {
sources = get_target_outputs(":convert_arm_assembly")
- deps = [ ":convert_arm_assembly" ]
configs -= [ "//build/config/compiler:compiler_arm_fpu" ]
configs += [ ":libvpx_config" ]
if (cpu_arch_full == "arm-neon" ||
cpu_arch_full == "arm-neon-cpu-detect") {
cflags = [ "-mfpu=neon" ]
}
+ deps = [
+ ":convert_arm_assembly",
+ ":gen_asm_offsets_vp8",
+ ":gen_asm_offsets_scale",
+ ]
}
}
@@ -239,10 +247,8 @@
} else if (cpu_arch == "arm64") {
sources = libvpx_srcs_arm64
}
- deps = [
- ":gen_asm_offsets_vp8",
- ]
configs += [ ":libvpx_config" ]
+ deps = []
if (cpu_arch == "x86" || (cpu_arch == "x64" && !is_msan)) {
deps += [
":libvpx_yasm",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698