Issue 570773002: Mojo: Add thread assertions to various private Channel methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 570773002: Mojo: Add thread assertions to various private Channel methods. (Closed)

Created:
6 years, 3 months ago by viettrungluu

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Add thread assertions to various private Channel methods. R=jamesr@chromium.org Committed: https://crrev.com/99dcd8fc555fb6bcbf35c16046cf3d319d8bcb49 Cr-Commit-Position: refs/heads/master@{#294724}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	mojo/system/channel.h	View		3 chunks	+12 lines, -8 lines	0 comments	Download
	M	mojo/system/channel.cc	View		5 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570773002/1

6 years, 3 months ago (2014-09-13 00:18:27 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as cbe0ea2b6581a0a44382b41691a219bc0dc7d07b

6 years, 3 months ago (2014-09-13 01:50:44 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-13 01:53:08 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99dcd8fc555fb6bcbf35c16046cf3d319d8bcb49
Cr-Commit-Position: refs/heads/master@{#294724}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages