Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 570763003: Remove unneeded bool from RenderView::selectionBounds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined (again and again) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/rendering/RenderBR.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index a3412a8914e0efd149548ae6b6363037a6e71825..393dc383bc01a8105cdbf4f50e93e13f0d5669c2 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1715,7 +1715,7 @@ String FrameSelection::selectedTextForClipboard() const
return selectedText();
}
-FloatRect FrameSelection::bounds(bool clipToVisibleContent) const
+FloatRect FrameSelection::bounds() const
{
m_frame->document()->updateRenderTreeIfNeeded();
@@ -1725,8 +1725,8 @@ FloatRect FrameSelection::bounds(bool clipToVisibleContent) const
if (!view || !renderView)
return FloatRect();
- LayoutRect selectionRect = renderView->selectionBounds(clipToVisibleContent);
- return clipToVisibleContent ? intersection(selectionRect, view->visibleContentRect()) : selectionRect;
+ LayoutRect selectionRect = renderView->selectionBounds();
+ return selectionRect;
}
static inline HTMLFormElement* associatedFormElement(HTMLElement& element)
@@ -1787,7 +1787,7 @@ void FrameSelection::revealSelection(const ScrollAlignment& alignment, RevealExt
rect = absoluteCaretBounds();
break;
case RangeSelection:
- rect = revealExtentOption == RevealExtent ? VisiblePosition(extent()).absoluteCaretBounds() : enclosingIntRect(bounds(false));
+ rect = revealExtentOption == RevealExtent ? VisiblePosition(extent()).absoluteCaretBounds() : enclosingIntRect(bounds());
break;
}
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/rendering/RenderBR.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698