Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 570763002: Remove more dependencies on sandbox/linux/seccomp-bpf (Closed)

Created:
6 years, 3 months ago by mdempsky
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove more dependencies on sandbox/linux/seccomp-bpf This started out as simply converting NaCl's baseline policy to bpf_dsl, but that led me down the rabbit hole of converting a bunch of remaining uses of SandboxBPFPolicy within content too. There are still a few lingering dependencies on sandbox_bpf.h after this CL, but not many. BUG=414363 Committed: https://crrev.com/4dd21732840c9ed934afb78a5943c6cc0b415bb8 Cr-Commit-Position: refs/heads/master@{#294871}

Patch Set 1 #

Patch Set 2 : Remove seccomp-bpf uses entirely #

Patch Set 3 : Revert DEPS check; still a couple legitimate seccomp-bpf uses #

Patch Set 4 : IWYU on Android #

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc View 1 4 chunks +18 lines, -17 lines 0 comments Download
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M content/common/sandbox_linux/bpf_ppapi_policy_linux.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_utility_policy_linux.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/sandbox_linux/sandbox_init_linux.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 1 2 3 4 4 chunks +5 lines, -7 lines 0 comments Download
M content/public/common/sandbox_init.h View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mdempsky
jln: PTAL! Touches a bunch of files, but the changes are just: 1. Convert NaCl's ...
6 years, 3 months ago (2014-09-13 01:30:09 UTC) #2
jln (very slow on Chromium)
lgtm
6 years, 3 months ago (2014-09-13 06:29:02 UTC) #3
mdempsky
creis: Please review/approve tiny refactoring to content/public/common/sandbox_init.h. Thanks!
6 years, 3 months ago (2014-09-14 02:07:30 UTC) #5
Charlie Reis
[+jam for content/public FYI] LGTM. Is there a bug number you can cite in the ...
6 years, 3 months ago (2014-09-15 18:11:27 UTC) #7
mdempsky
On 2014/09/15 18:11:27, Charlie Reis wrote: > LGTM. Is there a bug number you can ...
6 years, 3 months ago (2014-09-15 18:19:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570763002/80001
6 years, 3 months ago (2014-09-15 18:25:21 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-15 19:53:44 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:55:41 UTC) #13
Patchset 5 (id:??) landed as
https://crrev.com/4dd21732840c9ed934afb78a5943c6cc0b415bb8
Cr-Commit-Position: refs/heads/master@{#294871}

Powered by Google App Engine
This is Rietveld 408576698