Issue 57073004: DevTools: Add support for adding folders to DevTools workspace with drag and drop (browser part)

Issue 57073004: DevTools: Add support for adding folders to DevTools workspace with drag and drop (browser part) (Closed)

Created:
7 years, 1 month ago by vsevik

Modified:
7 years, 1 month ago

Reviewers:
kinuko, Tom Sepez, pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: Add support for adding folders to DevTools workspace with drag and drop (browser part) renderer part: https://codereview.chromium.org/57373002/ BUG=314476 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233070

Patch Set 2 : Comments addressed #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -2 lines)			Patch
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_file_helper.h	View		1 chunk	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/devtools_file_helper.cc	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_window.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/devtools_window.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

vsevik

Pavel, could you please review this? Kinuko, could you please review file system usage? Tom, ...

7 years, 1 month ago (2013-11-03 15:44:06 UTC) #1

pfeldman

lgtm https://codereview.chromium.org/57073004/diff/1/chrome/browser/devtools/devtools_file_helper.cc File chrome/browser/devtools/devtools_file_helper.cc (right): https://codereview.chromium.org/57073004/diff/1/chrome/browser/devtools/devtools_file_helper.cc#newcode331 chrome/browser/devtools/devtools_file_helper.cc:331: InnerAddFileSystem(callback, show_info_bar_callback, it->path); drop {}

7 years, 1 month ago (2013-11-05 06:10:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/57073004/80001

7 years, 1 month ago (2013-11-05 12:11:17 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97894

7 years, 1 month ago (2013-11-05 15:12:45 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/57073004/80001

7 years, 1 month ago (2013-11-05 16:59:53 UTC) #7

Message was sent while issue was closed.

Change committed as 233070

Expand Messages | Collapse Messages