Issue 570713006: Subzero: Refactor Operand::dump().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 570713006: Subzero: Refactor Operand::dump(). (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth

Modified:
6 years, 3 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Refactor Operand::dump(). A "standalone" version of dump() is provided, taking just an Ostream argument and not requiring a Cfg or GlobalContext argument. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2e8bfbb9e2a5be0271d771f197d629e6f7d3568e

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -38 lines)			Patch
M	src/IceInstX8632.h	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	1	7 chunks	+16 lines, -14 lines	0 comments	Download
M	src/IceOperand.h	View		7 chunks	+17 lines, -17 lines	0 comments	Download
M	src/IceOperand.cpp	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

A follow-on CL will do the same refactoring for Inst::dump().

6 years, 3 months ago (2014-09-15 21:13:51 UTC) #2

Jim Stichnoth

BTW, for the specific use case that Karl requested (the dump(Ostream &Str) version, I tested ...

6 years, 3 months ago (2014-09-15 21:29:58 UTC) #3

Jim Stichnoth

6 years, 3 months ago (2014-09-16 17:16:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 2e8bfbb (presubmit successful).