Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 570633002: Remove unsupported parameters by the unified gesture detector from Gesture Configuration. (Closed)

Created:
6 years, 3 months ago by lanwei
Modified:
6 years, 3 months ago
Reviewers:
sadrul, tdresser
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unsupported parameters by the unified gesture detector from Gesture Configuration. There are some parameters in the Gesture Configuration which are no longer used for unified gesture detector: max_radius_; min_flick_speed_squared_ min_rail_break_velocity_ min_scroll_delta_squared_ min_touch_down_duration_in_seconds_for_click_ rail_break_proportion_ rail_start_proportion_ scroll_prediction_seconds_ points_buffered_for_velocity_ BUG=380131 Committed: https://crrev.com/a2349a8f0fa116ff0794d48fefc0074312b2f126 Cr-Commit-Position: refs/heads/master@{#294975}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Delete points_buffered_for_velocity_ #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -111 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 8 chunks +47 lines, -22 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ui/events/gestures/gesture_configuration.h View 1 5 chunks +0 lines, -67 lines 0 comments Download
M ui/events/gestures/gesture_configuration.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
lanwei
6 years, 3 months ago (2014-09-12 16:20:34 UTC) #2
tdresser
https://codereview.chromium.org/570633002/diff/1/ui/events/gestures/gesture_configuration.cc File ui/events/gestures/gesture_configuration.cc (left): https://codereview.chromium.org/570633002/diff/1/ui/events/gestures/gesture_configuration.cc#oldcode43 ui/events/gestures/gesture_configuration.cc:43: int GestureConfiguration::points_buffered_for_velocity_ = 8; points_buffered_for_velocity_ isn't used anywhere, is ...
6 years, 3 months ago (2014-09-12 17:00:02 UTC) #3
lanwei
On 2014/09/12 17:00:02, tdresser wrote: > https://codereview.chromium.org/570633002/diff/1/ui/events/gestures/gesture_configuration.cc > File ui/events/gestures/gesture_configuration.cc (left): > > https://codereview.chromium.org/570633002/diff/1/ui/events/gestures/gesture_configuration.cc#oldcode43 > ...
6 years, 3 months ago (2014-09-12 18:36:47 UTC) #4
tdresser
Thanks for the cleanup! LGTM. Add points_buffered_for_velocity_ to the CL description. https://codereview.chromium.org/570633002/diff/20001/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (left): ...
6 years, 3 months ago (2014-09-12 18:39:58 UTC) #5
lanwei
Hello Sadrul, Can you please take a look at ui/aura/test/aura_test_base.cc, I removed some unused parameters ...
6 years, 3 months ago (2014-09-12 18:47:50 UTC) #7
sadrul
lgtm
6 years, 3 months ago (2014-09-15 13:37:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570633002/40001
6 years, 3 months ago (2014-09-16 00:37:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 919c3d6e882cf2e1429b5074c237c04704397e6a
6 years, 3 months ago (2014-09-16 02:11:25 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:13:27 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2349a8f0fa116ff0794d48fefc0074312b2f126
Cr-Commit-Position: refs/heads/master@{#294975}

Powered by Google App Engine
This is Rietveld 408576698