Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 570563006: MIPS64: Fixed int vs. uintptr_t confusion (plus some cleanup on the way). (Closed)

Created:
6 years, 3 months ago by akos.palfi.imgtec
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS64: Fixed int vs. uintptr_t confusion (plus some cleanup on the way). Port r23966 (a498d5e3) BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/test-platform.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
akos.palfi.imgtec
PTAL.
6 years, 3 months ago (2014-09-16 17:09:00 UTC) #2
paul.l...
LGTM, but this one needs v8 team review.
6 years, 3 months ago (2014-09-16 17:29:16 UTC) #4
Jakob Kummerow
lgtm
6 years, 3 months ago (2014-09-16 19:28:14 UTC) #6
akos.palfi.imgtec
6 years, 3 months ago (2014-09-16 20:16:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23986 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698