Compile chrome://settings, part 6

chrome/browser/resources/options/chromeos/internet_detail.js

Index: chrome/browser/resources/options/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js
index 5c0dc068dcf749fb18adc56141f5b9a3ddf3ceeb..55e12191ef76978da9e6d365d9efb45edf4d7b7b 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options/chromeos/internet_detail.js
@@ -354,11 +354,13 @@ cr.define('options.internet', function() {
      * Creates an indicator event for controlled properties using
      * the same dictionary format as CoreOptionsHandler::CreateValueForPref.
      * @param {string} name The name for the Event.
-     * @param {!{value: *, controlledBy: *, recommendedValue: *}} propData
-     *     Property dictionary,
+     * @param {Object} propData Property dictionary, Expected content:
+     *     {value: *, controlledBy: *, recommendedValue: *}.

[Dan Beam, 2014/09/12 03:25:19]

why?

[Vitaly Pavlenko, 2014/09/12 19:16:23]

Otherwise I need a cast on line 1447 (added), which adds extra code but doesn't
increase type safety.

      * @private
      */
     createControlledEvent_: function(name, propData) {
+      assert('value' in propData && 'controlledBy' in propData &&
+             'recommendedValue' in propData);
       var event = new Event(name);
       event.value = {
         value: propData.value,
@@ -1436,6 +1438,7 @@ cr.define('options.internet', function() {
           onc.getActiveValue(propName);
       if (propValue == undefined)
         continue;
+      propValue = assertInstanceof(propValue, Object);
       var event;
       if (managed)
         event = detailsPage.createManagedEvent_(propName, propValue);