chrome/browser/resources/options/chromeos/accounts_user_name_edit.js - Issue 570503002: Compile chrome://settings, part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/browser_options.js ('K') | « chrome/browser/resources/options/chromeos/accounts_user_list.js ('k') | chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js » ('j') | chrome/browser/resources/options/chromeos/display_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

diff --git a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

index f26a3b6d687b5092770793fa2fd102b8489f1f1c..43fd82d6a0553c3e334ace11768e37025915a3a7 100644

--- a/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

+++ b/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js

@@ -105,9 +105,10 @@ cr.define('options.accounts', function() {

/**

* Handler for key down event.

* @private

- * @param {!Event} e The keydown event object.

+ * @param {Event} e The keydown event object.

handleKeyDown_: function(e) {

+ assert(e);

Dan Beam 2014/09/12 03:25:19 i'd just remove this. i have no idea why this wou

Vitaly Pavlenko 2014/09/12 19:16:22 Done.

if (e.keyIdentifier == 'Enter') {

var user = this.parse(this.value);

if (user) {