Compile chrome://settings, part 6

chrome/browser/resources/options/chromeos/network_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/**
+ * @typedef {{
+ *   ConnectionState: string,
+ *   iconURL: string,
+ *   policyManaged: boolean,
+ *   servicePath: string
+ * }}
+ * @see chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
+ */
+var NetworkInfo;
+
 cr.define('options.network', function() {
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var List = cr.ui.List;
   var ListItem = cr.ui.ListItem;
   var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
   var Menu = cr.ui.Menu;
   var MenuItem = cr.ui.MenuItem;
   var ControlledSettingIndicator = options.ControlledSettingIndicator;
 
   /**
@@ skipping 347 matching lines @@
         this.menu_.hidden = false;
       }
       if (rescan)
         chrome.send('refreshNetworks');
     },
   };
 
   /**
    * Creates a control for selecting or configuring a network connection based
    * on the type of connection (e.g. wifi versus vpn).
-   * @param {{key: string, networkList: Array.<Object>}} data Description of the
-   *     network.
+   * @param {{key: string, networkList: Array.<NetworkInfo>}} data Description
+   *     of the network.
    * @constructor
    * @extends {NetworkMenuItem}
    */
   function NetworkSelectorItem(data) {
     var el = new NetworkMenuItem(data);
     el.__proto__ = NetworkSelectorItem.prototype;
     el.decorate();
     return el;
   }
 
@@ skipping 229 matching lines @@
           discardOnClose = true;
         }
       }
       oldMenu.data = {discardOnClose: discardOnClose};
       return true;
     },
 
     /**
      * Extracts a mapping of network names to menu element and position.
      * @param {!Element} menu The menu to process.
-     * @return {Object.<string, {index: number, button: Element}>}
+     * @return {Object.<string, ?{index: number, button: Element}>}
      *     Network mapping.
      * @private
      */
     extractNetworkConnectButtons_: function(menu) {
       var group = menu.getElementsByClassName('network-menu-group')[0];
       var networkButtons = {};
       if (!group)
         return networkButtons;
       var buttons = group.getElementsByClassName('network-menu-item');
       for (var i = 0; i < buttons.length; i++) {
@@ skipping 249 matching lines @@
           this.dataModel.splice(referenceIndex + 1, 0, data);
         }
       } else {
         var entry = this.dataModel.item(index);
         data.sortIndex = entry.sortIndex;
         this.dataModel.splice(index, 1, data);
       }
       this.endBatchUpdates();
     },
 
-    /** @override */
+    /**
+     * @override
+     * @param {Object} entry
+     */
     createItem: function(entry) {
       if (entry.networkList)
-        return new NetworkSelectorItem(entry);
+        return new NetworkSelectorItem(
+            /** @type {{key: string, networkList: Array.<NetworkInfo>}} */(
+              entry));

[Dan Beam, 2014/09/12 03:25:19]

indent off

[Vitaly Pavlenko, 2014/09/12 19:16:23]

This way?

[Dan Beam, 2014/09/16 01:04:14]

yes

[Vitaly Pavlenko, 2014/09/16 03:11:20]

Acknowledged.

       if (entry.command)
-        return new NetworkButtonItem(entry);
+        return new NetworkButtonItem(
+            /** @type {{key: string, subtitle: string, command: Function}} */(
+              entry));
       if (entry.menu)
         return new NetworkMenuItem(entry);
       return undefined;
     },
 
     /**
      * Deletes an element from the list.
      * @param {string} key  Unique identifier for the element.
      */
     deleteItem: function(key) {
@@ skipping 22 matching lines @@
    * Sets the default icon to use for each network type if disconnected.
    * @param {!Object.<string, string>} data Mapping of network type to icon
    *     data url.
    */
   NetworkList.setDefaultNetworkIcons = function(data) {
     defaultIcons_ = Object.create(data);
   };
 
   /**
    * Chrome callback for updating network controls.
-   * @param {{wiredList: Array, wirelessList: Array, vpnList: Array,
-   *     rememberedList: Array, wifiAvailable: boolean, wifiEnabled: boolean,
-   *     wimaxAvailable: boolean, wimaxEnabled: boolean,
-   *     cellularAvailable: boolean, cellularEnabled: boolean,
-   *     cellularSupportsScan: boolean}} data Description of available network
-   *     devices and their corresponding state.
+   * @param {{wiredList: Array.<NetworkInfo>, wirelessList: Array.<NetworkInfo>,
+   *     vpnList: Array.<NetworkInfo>, rememberedList: Array.<NetworkInfo>,
+   *     wifiAvailable: boolean, wifiEnabled: boolean, wimaxAvailable: boolean,
+   *     wimaxEnabled: boolean, cellularAvailable: boolean,
+   *     cellularEnabled: boolean, cellularSupportsScan: boolean}} data
+   *     Description of available network devices and their corresponding state.
    */
   NetworkList.refreshNetworkData = function(data) {
     var networkList = $('network-list');
     networkList.startBatchUpdates();
     cellularAvailable_ = data.cellularAvailable;
     cellularEnabled_ = data.cellularEnabled;
     cellularSupportsScan_ = data.cellularSupportsScan;
     wimaxAvailable_ = data.wimaxAvailable;
     wimaxEnabled_ = data.wimaxEnabled;
 
@@ skipping 198 matching lines @@
   /**
    * Whether the Network list is disabled. Only used for display purpose.
    */
   cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   // Export
   return {
     NetworkList: NetworkList
   };
 });