Compile chrome://settings, part 6

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
@@ skipping 632 matching lines @@
       this.addExtensionControlledBox_('startup-section-content',
                                       'startpage-controlled',
                                       false);
       this.addExtensionControlledBox_('newtab-section-content',
                                       'newtab-controlled',
                                       false);
       this.addExtensionControlledBox_('proxy-section-content',
                                       'proxy-controlled',
                                       true);
 
       document.body.addEventListener('click', function(e) {

[Dan Beam, 2014/09/12 03:25:19]

var target = assertInstanceof(e.target, Node);

[Vitaly Pavlenko, 2014/09/12 19:16:22]

Done.

-        var button = findAncestor(e.target, function(el) {
+        var button = findAncestor(assertInstanceof(e.target, Node),
+            function(el) {
           return el.tagName == 'BUTTON' &&
                  el.dataset.extensionId !== undefined &&
                  el.dataset.extensionId.length;
         });
         if (button)
           chrome.send('disableExtension', [button.dataset.extensionId]);
       });
     },
 
     /** @override */
@@ skipping 35 matching lines @@
         StartupOverlay.getInstance().updateControlStates();
       }
     },
 
     /**
      * Handler for messages sent from the main uber page.
      * @param {Event} e The 'message' event from the uber page.
      * @private
      */
     handleWindowMessage_: function(e) {
-      if (e.data.method == 'frameSelected')
+      if ((/** @type {{method: string}} */(e.data)).method == 'frameSelected')
         $('search-field').focus();
     },
 
     /**
      * Animatedly changes height |from| a px number |to| a px number.
      * @param {HTMLElement} section The section to animate.
      * @param {HTMLElement} container The container of |section|.
      * @param {boolean} showing Whether to go from 0 -> container height or
      *     container height -> 0.
      * @private
@@ skipping 513 matching lines @@
      * Sets or clear whether Chrome should Auto-launch on computer startup.
      * @private
      */
     handleAutoLaunchChanged_: function() {
       chrome.send('toggleAutoLaunch', [$('auto-launch').checked]);
     },
 
     /**
      * Get the selected profile item from the profile list. This also works
      * correctly if the list is not displayed.
-     * @return {Object} the profile item object, or null if nothing is selected.
+     * @return {?Object} The profile item object, or null if nothing is
+     *     selected.
      * @private
      */
     getSelectedProfileItem_: function() {
       var profilesList = $('profiles-list');
       if (profilesList.hidden) {
         if (profilesList.dataModel.length > 0)
           return profilesList.dataModel.item(0);
       } else {
         return profilesList.selectedItem;
       }
@@ skipping 757 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });