Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(320)

Issue 570463002: Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (Closed)

Created:
5 years, 11 months ago by nasko
Modified:
5 years, 11 months ago
Reviewers:
Sergey Ulanov, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_dgrams
Project:
chromium
Visibility:
Public.

Description

Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (patchset #5 id:100001 of https://codereview.chromium.org/551173004/) Reason for revert: Failed to compile on android builder. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485 In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0, from ../../remoting/protocol/pseudotcp_channel_factory.cc:5: ../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type virtual void CreateChannel(const std::string& name, ^ ../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type virtual void CancelChannelCreation(const std::string& name) = 0; ... Original issue's description: > Move PseudoTCP and channel auth out of LibjingleTransportFactory. > > Previously TransportFactory interface was responsible for creation > and initialization of several protocol layers, including PseudoTCP and > authentication (TLS). Simplified it so now it only creates raw datagram > transport channel. PseudoTcpChannelFactory is now responsible for > setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care > of channel authentication. Also added DatagramChannelFactory for > Datagram channels. > > This change will make it possible to replace PseudoTcpChannelFactory > with an object that creates SCTP-based channels. > > Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working > properly when deleted from the callback. (base::Callback objects > shouldn't be deleted while being called because when deleted they > also destroy reference parameters values they are holding). > > BUG=402993 > > Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10 > Cr-Commit-Position: refs/heads/master@{#294474} TBR=wez@chromium.org,sergeyu@chromium.org NOTREECHECKS=true NOTRY=true BUG=402993 Committed: https://crrev.com/8a450db4c2c791465a570184ac5281102cfca232 Cr-Commit-Position: refs/heads/master@{#294488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -605 lines) Patch
M remoting/protocol/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M remoting/protocol/authenticator_test_base.h View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/channel_authenticator.h View 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.cc View 1 chunk +1 line, -1 line 0 comments Download
A remoting/protocol/channel_factory.h View 1 chunk +54 lines, -0 lines 0 comments Download
M remoting/protocol/channel_multiplexer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/protocol/datagram_channel_factory.h View 1 chunk +0 lines, -45 lines 0 comments Download
M remoting/protocol/fake_authenticator.h View 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 4 chunks +19 lines, -30 lines 0 comments Download
M remoting/protocol/fake_session.h View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.h View 5 chunks +6 lines, -14 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 6 chunks +19 lines, -31 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 17 chunks +161 lines, -50 lines 0 comments Download
M remoting/protocol/protobuf_video_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/protobuf_video_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/protobuf_video_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/protobuf_video_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
D remoting/protocol/pseudotcp_channel_factory.h View 1 chunk +0 lines, -52 lines 0 comments Download
D remoting/protocol/pseudotcp_channel_factory.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D remoting/protocol/secure_channel_factory.h View 1 chunk +0 lines, -60 lines 0 comments Download
D remoting/protocol/secure_channel_factory.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M remoting/protocol/session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 3 chunks +5 lines, -11 lines 0 comments Download
D remoting/protocol/stream_channel_factory.h View 1 chunk +0 lines, -52 lines 0 comments Download
M remoting/protocol/transport.h View 3 chunks +33 lines, -7 lines 0 comments Download
M remoting/remoting_srcs.gypi View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nasko
Created Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory.
5 years, 11 months ago (2014-09-11 22:36:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570463002/1
5 years, 11 months ago (2014-09-11 22:38:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f50c28612cb64a9713dc78d006518e977c6ce784
5 years, 11 months ago (2014-09-11 23:21:49 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2014-09-11 23:32:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a450db4c2c791465a570184ac5281102cfca232
Cr-Commit-Position: refs/heads/master@{#294488}

Powered by Google App Engine
This is Rietveld 408576698