Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 570443002: Suppress opus warning about optimization in opus_nacl (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress opus warning about optimization in opus_nacl See also https://trac.xiph.org/ticket/2048 BUG=355440 Committed: https://crrev.com/09dc114cac5e71e55a5b879261856cf3bfaffb5f Cr-Commit-Position: refs/heads/master@{#294650}

Patch Set 1 #

Patch Set 2 : Stop suppressing warnings as errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/opus/opus_nacl.gyp View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmichael (off chromium)
See also https://code.google.com/p/chromium/issues/detail?id=413450 I think turning on optimization is a better longer-term solution, which I'm ...
6 years, 3 months ago (2014-09-11 23:11:38 UTC) #2
Sergey Ulanov
lgtm
6 years, 3 months ago (2014-09-12 18:17:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570443002/20001
6 years, 3 months ago (2014-09-12 18:30:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b2f9196ebf8d6ea50a408cd4a82247410867c224
6 years, 3 months ago (2014-09-12 20:32:41 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 20:42:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09dc114cac5e71e55a5b879261856cf3bfaffb5f
Cr-Commit-Position: refs/heads/master@{#294650}

Powered by Google App Engine
This is Rietveld 408576698