Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 570303003: ash: Avoid treating screen resizes as user activity. (Closed)

Created:
6 years, 3 months ago by Daniel Erat
Modified:
6 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ash: Avoid treating screen resizes as user activity. Tell UserActivityDetector to ignore mouse events received soon after notification that displays have been changed. Previously, the events were only ignored after making requests to configure displays, but this appears to be insufficient in some cases where configuration takes longer than a second. BUG=360634 Committed: https://crrev.com/2430b2a3cfbdf230c24b7ac05a19a07eb57cca90 Cr-Commit-Position: refs/heads/master@{#295482}

Patch Set 1 #

Patch Set 2 : check that UserActivityDetector exists #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ash/display/display_change_observer_chromeos.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
this is fairly gross, but the only alternative i can think of is increasing the ...
6 years, 3 months ago (2014-09-16 15:19:03 UTC) #2
dnicoara
lgtm I did a bit of reading and I suspect that the mouse events are ...
6 years, 3 months ago (2014-09-16 15:42:21 UTC) #3
Daniel Erat
putting in the CQ after adding a guard for a NULL UserActivityDetector (it looks like ...
6 years, 3 months ago (2014-09-18 14:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/570303003/20001
6 years, 3 months ago (2014-09-18 14:43:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 98a76a10bdd3879c0946dacd88c28100fee81dc6
6 years, 3 months ago (2014-09-18 16:40:56 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 16:41:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2430b2a3cfbdf230c24b7ac05a19a07eb57cca90
Cr-Commit-Position: refs/heads/master@{#295482}

Powered by Google App Engine
This is Rietveld 408576698