Componentize NetErrorHelperCore

components/error_page/common/error_page_params.h

Index: components/error_page/common/error_page_params.h
diff --git a/components/error_page/common/error_page_params.h b/components/error_page/common/error_page_params.h
new file mode 100644
index 0000000000000000000000000000000000000000..a48e35e5a47ac34f95a83594fcae5be79c53ec8b
--- /dev/null
+++ b/components/error_page/common/error_page_params.h
@@ -0,0 +1,43 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NET_ERROR_COMMON_ERROR_PAGE_PARAMS_H_
+#define COMPONENTS_NET_ERROR_COMMON_ERROR_PAGE_PARAMS_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "url/gurl.h"
+
+namespace base {
+class ListValue;
+}
+
+namespace error_page {
+
+// Optional parameters that affect the display of an error page.
+struct ErrorPageParams {

[mmenke, 2014/09/16 14:45:05]

It seems kinda weird to separate this out from LocalizedError.  Do you have any
plans to actually hook this up?

[hashimoto, 2014/09/16 16:12:03]

It might look weird when you consider ErrorPageParams as a part of
LocalizedError interface.
But, I think it might make sense if you consider this struct as a part of
NetErrorHelperCore::Delegate interface.
Since, ideally, NetErrorHelperCore shouldn't be aware of how the delegate
implements GenerateLocalizedErrorPage() method, I think NetErrorHelperCore
shouldn't depend on LocalizedError.


Regarding LocalizedError itself, I cannot be sure when it gets componentized
because it's using a number of string resources from chromium_strings.h.
Since componentized code can be used from binaries other than chrome (e.g.
athena and app_shell), some strings from chromium_strings.h might be too
chrome-specific to be used on other binaries.

My current plan is to componentize LocalizedError in long term.
For short term, however, I want to introduce an interface which abstracts
LocalizedError so chrome can use LocalizedError to return the real strings while
other binaries like athena can implement a stub which returns almost nothing.
Does this sound good to you?
Should we immediately componentize LocalizedError instead?

+  ErrorPageParams();
+  ~ErrorPageParams();
+
+  // Overrides whether reloading is suggested.
+  bool suggest_reload;
+  int reload_tracking_id;
+
+  // Overrides default suggestions.  Each entry must contain a header and may
+  // optionally contain a body as well.  Must not be NULL.
+  scoped_ptr<base::ListValue> override_suggestions;
+
+  // Prefix to prepend to search terms.  Search box is only shown if this is
+  // a valid url.  The search terms will be appended to the end of this URL to
+  // conduct a search.
+  GURL search_url;
+  // Default search terms.  Ignored if |search_url| is invalid.
+  std::string search_terms;
+  int search_tracking_id;
+};
+
+}  // namespace error_page
+
+#endif  // COMPONENTS_NET_ERROR_COMMON_ERROR_PAGE_PARAMS_H_