Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: components/error_page/renderer/net_error_helper_core.h

Issue 570253002: Componentize NetErrorHelperCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/error_page/renderer/DEPS ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/renderer/net_error_helper_core.h
diff --git a/chrome/renderer/net/net_error_helper_core.h b/components/error_page/renderer/net_error_helper_core.h
similarity index 96%
rename from chrome/renderer/net/net_error_helper_core.h
rename to components/error_page/renderer/net_error_helper_core.h
index b09535bf5a7dc28d801bd179bf6f1f0710d86897..ec00d335d6bc132ab91551a3257ada26eae03533 100644
--- a/chrome/renderer/net/net_error_helper_core.h
+++ b/components/error_page/renderer/net_error_helper_core.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_CORE_H_
-#define CHROME_RENDERER_NET_NET_ERROR_HELPER_CORE_H_
+#ifndef COMPONENTS_ERROR_PAGE_RENDERER_NET_ERROR_HELPER_CORE_H_
+#define COMPONENTS_ERROR_PAGE_RENDERER_NET_ERROR_HELPER_CORE_H_
#include <string>
@@ -11,8 +11,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/timer/timer.h"
-#include "chrome/common/localized_error.h"
-#include "chrome/common/net/net_error_info.h"
+#include "components/error_page/common/net_error_info.h"
#include "url/gurl.h"
namespace base {
@@ -23,6 +22,10 @@ namespace blink {
struct WebURLError;
}
+namespace error_page {
+
+struct ErrorPageParams;
+
// Class that contains the logic for how the NetErrorHelper. This allows for
// testing the logic without a RenderView or WebFrame, which are difficult to
// mock, and for testing races which are impossible to reliably reproduce
@@ -54,7 +57,7 @@ class NetErrorHelperCore {
virtual void GenerateLocalizedErrorPage(
const blink::WebURLError& error,
bool is_failed_post,
- scoped_ptr<LocalizedError::ErrorPageParams> params,
+ scoped_ptr<error_page::ErrorPageParams> params,
bool* reload_button_shown,
bool* load_stale_button_shown,
std::string* html) const = 0;
@@ -263,4 +266,6 @@ class NetErrorHelperCore {
Button navigation_from_button_;
};
-#endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_CORE_H_
+} // namespace error_page
+
+#endif // COMPONENTS_ERROR_PAGE_RENDERER_NET_ERROR_HELPER_CORE_H_
« no previous file with comments | « components/error_page/renderer/DEPS ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698