components/error_page/common/BUILD.gn - Issue 570253002: Componentize NetErrorHelperCore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/common/BUILD.gn

Issue 570253002: Componentize NetErrorHelperCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/common/BUILD.gn

diff --git a/components/history/core/common/BUILD.gn b/components/error_page/common/BUILD.gn

similarity index 66%

copy from components/history/core/common/BUILD.gn

copy to components/error_page/common/BUILD.gn

index 7a493141978ebc86786ede32720f563e8a537d74..b3c5b88cb13dfb9f55878614e8a9f3ca480c3320 100644

--- a/components/history/core/common/BUILD.gn

+++ b/components/error_page/common/BUILD.gn

@@ -4,11 +4,14 @@

static_library("common") {

sources = [

- "thumbnail_score.cc",

- "thumbnail_score.h",

+ "error_page_params.cc",

+ "error_page_params.h",

+ "net_error_info.cc",

+ "net_error_info.h",

]

deps = [

"//base",

+ "//url",

]

« no previous file with comments | « components/error_page/OWNERS ('k') | components/error_page/common/error_page_params.h » ('j') | no next file with comments »