components/error_page_strings.grdp - Issue 570253002: Componentize NetErrorHelperCore

Side by Side Diff: components/error_page_strings.grdp

Issue 570253002: Componentize NetErrorHelperCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix OWNERS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3

	4 <message name="IDS_ERRORPAGES_SUGGESTION_VISIT_GOOGLE_CACHE" desc="When a page fails to load, sometimes we viewing a version of the page cached on Google's se rvers.">

	5 Access a <ph name="BEGIN_LINK"><a jsvalues="href:urlCorrection;.jstdata:$ this" onmousedown="linkClicked(this.jstdata)"></ph>cached copy<ph name="END_L INK"></a></ph> of <ph name="URL"><span jscontent="originalUrlForDisplay "></span><ex>www.hats-for-goats.com/shiny</ex></ph>

	6 </message>

	7 <message name="IDS_ERRORPAGES_SUGGESTION_CORRECTED_URL" desc="When a page fail s to load, sometimes we suggest different URL because we think the one the user entered had a typo.">

	8 Did you mean <ph name="LINK"><a jsvalues="href:urlCorrection;.jstdata:$th is" onmousedown="linkClicked(this.jstdata)" jscontent="urlCorrectionForDisplay"& gt;</a><ex>www.somewhere-spelled-correctly.com</ex></ph>?

	9 </message>

	10 <message name="IDS_ERRORPAGES_SUGGESTION_ALTERNATE_URL" desc="When a page fail s to load, sometimes we suggest different URL (maybe a different page on the sam e site, or a site with similar content, for example).">

	11 Go to <ph name="LINK"><a jsvalues="href:urlCorrection;.jstdata:$this" onm ousedown="linkClicked(this.jstdata)" jscontent="urlCorrectionForDisplay">< /a><ex>www.somewhere.com</ex></ph>
	mmenke 2014/09/18 17:50:42 These seem really weird - they call functions from These seem really weird - they call functions from outside the component. hashimoto 2014/09/22 09:28:12 Oops, I didn't expect string resources to contain Show quoted text On 2014/09/18 17:50:42, mmenke wrote: > These seem really weird - they call functions from outside the component. Oops, I didn't expect string resources to contain JS code. The file which contains the function linkClicked() will be componentized when it's exclusive user, NetErrorHelper, gets componentized. If it's not OK to leave these string resources in this state until then, maybe we should componentize these files (neterror.js and its relatives) even though it's not used by anyone in this component yet? mmenke 2014/09/23 15:04:34 neterror.js is used on iOS, so it should not be pa Show quoted text On 2014/09/22 09:28:12, hashimoto wrote: > On 2014/09/18 17:50:42, mmenke wrote: > > These seem really weird - they call functions from outside the component. > > Oops, I didn't expect string resources to contain JS code. > > The file which contains the function linkClicked() will be componentized when > it's exclusive user, NetErrorHelper, gets componentized. > If it's not OK to leave these string resources in this state until then, maybe > we should componentize these files (neterror.js and its relatives) even though > it's not used by anyone in this component yet? neterror.js is used on iOS, so it should not be part of a component that depends on content/. Any component that includes NetErrorHelper will have to depend on content/. (With just NetErrorHelperCore, that dependency could trivially be removed) hashimoto 2014/09/24 10:59:41 iOS can depend on content-free part of this compon Show quoted text On 2014/09/23 15:04:34, mmenke wrote: > On 2014/09/22 09:28:12, hashimoto wrote: > > On 2014/09/18 17:50:42, mmenke wrote: > > > These seem really weird - they call functions from outside the component. > > > > Oops, I didn't expect string resources to contain JS code. > > > > The file which contains the function linkClicked() will be componentized when > > it's exclusive user, NetErrorHelper, gets componentized. > > If it's not OK to leave these string resources in this state until then, maybe > > we should componentize these files (neterror.js and its relatives) even though > > it's not used by anyone in this component yet? > > neterror.js is used on iOS, so it should not be part of a component that depends > on content/. Any component that includes NetErrorHelper will have to depend on > content/. (With just NetErrorHelperCore, that dependency could trivially be > removed) iOS can depend on content-free part of this component. (i.e. error_page_common) Auto-reload for iOS will not use NetErrorHelper as iOS doesn't have the idea of renderer processes. (You can track the status of iOS's autoreload feature at http://crbug.com/329623)
	12 </message>

	13

	14 </grit-part>

OLD	NEW

« components/error_page/renderer/net_error_helper_core.cc ('K') | « components/error_page/renderer/net_error_helper_core_unittest.cc ('k') | no next file » | no next file with comments »