Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 57025: Make the font family and the font size used in dom UI localizable. ... (Closed)

Created:
11 years, 8 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make the font family and the font size used in dom UI localizable. This is a part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI. For some Indian languages (Malayalam, Bengali and Telugu), we have to use a bigger size and a font family for that script on Windows. This is because Windows' stock fonts for those scripts are smaller than fonts for other scripts at a given size. I removed 'WEB' style in chrome_font.h because it's not used anywhere any more after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is recycled to localize the font family (or the list of font families) for html UI. I also back-ported the support for setting 'style.fooBar' property to our copy of Jstemplate (JstProcessor.prototype.jstValues_). BUG=7319 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13114

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -49 lines) Patch
M chrome/app/resources/locale_settings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ar.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bg.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bn.xtb View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/resources/locale_settings_ca.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_cs.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_da.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_de.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_el.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_en-GB.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es-419.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_et.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fil.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_gu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_he.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
chrome/app/resources/locale_settings_hu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_id.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_it.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ja.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_kn.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ko.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lt.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ml.xtb View 1 7 8 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/resources/locale_settings_mr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nb.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_or.xtb View 1 chunk +1 line, -0 lines 0 comments Download
chrome/app/resources/locale_settings_pl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-BR.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-PT.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ro.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ru.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ta.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_te.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_th.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_tr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_uk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_vi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/downloads.html View 4 5 6 7 8 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/history.html View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/incognito_tab.html View 4 5 6 7 8 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/new_tab.html View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/gfx/chrome_font.h View 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
chrome/common/gfx/chrome_font_win.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/resource_bundle.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/resource_bundle.cc View 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/third_party/jstemplate/jstemplate.js View 1 chunk +17 lines, -4 lines 0 comments Download
M chrome/third_party/jstemplate/jstemplate_compiled.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
11 years, 8 months ago (2009-03-30 23:38:16 UTC) #1
Glen Murphy
General: why not use JSTemplate to modify the style attributes of the body tag instead ...
11 years, 8 months ago (2009-03-31 18:21:40 UTC) #2
jungshik at Google
Can you take another look? After a lot of tinkering (due to the fact that ...
11 years, 8 months ago (2009-04-01 23:04:35 UTC) #3
jungshik at Google
Glen, Can you review the CL? As we discussed offline, this approach is not to ...
11 years, 8 months ago (2009-04-03 17:03:18 UTC) #4
Glen Murphy
11 years, 8 months ago (2009-04-03 17:40:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698