Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: build/config/android/rules.gni

Issue 570203002: Make chrome_shell_apk build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-chrome-jamesr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index cf72ddd17f87d2fa11064eb1da030cc7c40754a2..8269c711be6cee7c2b5b1d100c4a37aeedf2bc5d 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -34,8 +34,9 @@ template("generate_jni") {
assert(defined(invoker.sources))
assert(defined(invoker.jni_package))
jni_package = invoker.jni_package
- base_output_dir = "${root_gen_dir}/${target_name}/${jni_package}"
- jni_output_dir = "${base_output_dir}/jni"
+ base_output_dir = "${target_gen_dir}/${target_name}"
+ package_output_dir = "${base_output_dir}/${jni_package}"
+ jni_output_dir = "${package_output_dir}/jni"
jni_generator_include = "//base/android/jni_generator/jni_generator_helper.h"
@@ -66,7 +67,13 @@ template("generate_jni") {
}
config("jni_includes_${target_name}") {
- include_dirs = [ base_output_dir ]
+ # TODO(cjhopman): #includes should probably all be relative to
+ # base_output_dir. Remove that from this config once the includes are
+ # updated.
+ include_dirs = [
+ base_output_dir,
+ package_output_dir,
+ ]
}
group(target_name) {
@@ -79,6 +86,8 @@ template("generate_jni") {
if (defined(invoker.forward_dependent_configs_from)) {
forward_dependent_configs_from = invoker.forward_dependent_configs_from
}
+
+ if (defined(invoker.visibility)) { visibility = invoker.visibility }
}
}
@@ -976,8 +985,9 @@ template("unittest_apk") {
android_manifest = "//testing/android/java/AndroidManifest.xml"
unittests_outputs = [ unittests_binary ]
native_libs = [unittests_outputs[0]]
+ deps = [ "//base:base_java" ]
if (defined(invoker.deps)) {
- deps = invoker.deps
+ deps += invoker.deps
}
datadeps = [
"//tools/android/md5sum",

Powered by Google App Engine
This is Rietveld 408576698