Make chrome_shell_apk build

Make chrome_shell_apk build

This mostly just adds the chrome_shell_apk build definition and those of
a whole bunch of targets.

Adds a simple check that when DEPRECATED_java_in_dir is used, it
actually includes the "src" at the end (GYP just assumes that you really
meant that java files are in <(java_in_dir)/src).

Makes the call to process_resources only generate R.java for extra
packages when being run as part of the apk step (otherwise, for
example, both chrome resources and content resources would contain
an R.java for net resources and compilation would fail).

Depends on https://codereview.chromium.org/581273004/

Adds the following targets -- and enables ~300 more (550 counting
template-generated inner targets):

//chrome:chrome_android_core
//chrome/android:chrome_strings_grd
//chrome/android:chrome_java
//chrome/android:activity_type_ids_javagen
//chrome/android:app_banner_metrics_ids_javagen
//chrome/android:resource_id_javagen
//chrome/android:profile_account_management_metrics_javagen
//chrome/android:profile_sync_service_model_type_selection_javagen
//chrome/android:toolbar_model_security_levels_javagen
//chrome/android:tab_load_status_javagen
//chrome/android:chrome_shell_base
//chrome/android:chrome_shell
//chrome/android:chrome_sync_shell
//chrome/android:chrome_shell_resources
//chrome/android:chrome_shell_java
//chrome/android:chrome_shell_assets
//chrome/android:chrome_shell_apk
//chrome/android:chrome_sync_shell_apk
//components/bookmarks:bookmarks_java
//components/bookmarks:bookmarks_jni_headers
//components/bookmarks:bookmark_type_javagen
//components/dom_distiller/android:dom_distiller_core_java
//components/dom_distiller/android:dom_distiller_core_font_family_javagen
//components/dom_distiller/android:dom_distiller_core_theme_javagen
//components/enhanced_bookmarks:jni_headers
//components/enhanced_bookmarks/android:enhanced_bookmarks_java
//components/gcm_driver:gcm_driver_java
//components/gcm_driver:jni_headers
//components/navigation_interception/android:navigation_interception_java
//components/variations:variations_java
//components/web_contents_delegate_android:web_contents_delegate_android
//components/web_contents_delegate_android:web_contents_delegate_android_java
//components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
//printing:printing_java
//sync:fake_server_jni
//sync:sync_java_test_support
//sync:test_support_sync_fake_server_android
//sync:sync_unit_tests_apk
//sync/android:sync_java
//sync/android:sync_javatests

BUG=359249
TBR=ben

Committed: https://crrev.com/11a68cbf1df1110ebac0b649edf2aef22682387e
Cr-Commit-Position: refs/heads/master@{#299381}

[cjhopman, 2014-09-19 01:53:10]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-09-19 01:53:11]

brettw: *

This is a little big, but it's mostly trivial conversions.

[cjhopman, 2014-09-19 01:55:49]

https://codereview.chromium.org/570203002/diff/60001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/60001/chrome/android/BUILD.gn#...
chrome/android/BUILD.gn:207: shared_library("chrome_shell") {
jamesr, I know you've been working at getting chrome building for android, so if
you wanted more of that: once we get this target linking, chrome_shell_apk
should run (content_shell_apk currently gets a render crash in v8, so we'll
probably get that here too).

[brettw, 2014-10-09 17:05:31]

lgtm

https://codereview.chromium.org/570203002/diff/80001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/570203002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:576: 
Nit: two blank lines.

https://codereview.chromium.org/570203002/diff/80001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/chrome/BUILD.gn#newcode534
chrome/BUILD.gn:534: deps = [
Ordering should be sources, includes/libs, deps.

https://codereview.chromium.org/570203002/diff/80001/components/web_contents_...
File components/web_contents_delegate_android/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/components/web_contents_...
components/web_contents_delegate_android/BUILD.gn:18:
":web_contents_delegate_android_jni_headers",
This should be first.

https://codereview.chromium.org/570203002/diff/80001/sync/BUILD.gn
File sync/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/sync/BUILD.gn#newcode796
sync/BUILD.gn:796: deps = [
swap deps and sources.

[cjhopman, 2014-10-10 01:10:09]

https://codereview.chromium.org/570203002/diff/80001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/570203002/diff/80001/build/config/android/int...
build/config/android/internal_rules.gni:576: 
On 2014/10/09 17:05:31, brettw wrote:
> Nit: two blank lines.

Done.

https://codereview.chromium.org/570203002/diff/80001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/chrome/BUILD.gn#newcode534
chrome/BUILD.gn:534: deps = [
On 2014/10/09 17:05:31, brettw wrote:
> Ordering should be sources, includes/libs, deps.

Done.

https://codereview.chromium.org/570203002/diff/80001/components/web_contents_...
File components/web_contents_delegate_android/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/components/web_contents_...
components/web_contents_delegate_android/BUILD.gn:18:
":web_contents_delegate_android_jni_headers",
On 2014/10/09 17:05:31, brettw wrote:
> This should be first.

Done.

https://codereview.chromium.org/570203002/diff/80001/sync/BUILD.gn
File sync/BUILD.gn (right):

https://codereview.chromium.org/570203002/diff/80001/sync/BUILD.gn#newcode796
sync/BUILD.gn:796: deps = [
On 2014/10/09 17:05:31, brettw wrote:
> swap deps and sources.

Done.

[cjhopman, 2014-10-10 01:11:32]

cjhopman@chromium.org changed reviewers:
+ ben@chromium.org, jochen@chromium.org

[cjhopman, 2014-10-10 01:11:33]

jochen: components/
ben@ for OWNERS of chrome/ + some random other bits

[Ben Goodger (Google), 2014-10-10 03:30:16]

Can you be more precise about "random other bits"?

On Thu, Oct 9, 2014 at 6:11 PM, <cjhopman@chromium.org> wrote:

> jochen: components/
> ben@ for OWNERS of chrome/ + some random other bits
>
> https://codereview.chromium.org/570203002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-10-10 11:12:21]

do you actually want me to do an indepth review, or just rubberstamp brett's
review?

[cjhopman, 2014-10-10 16:32:52]

cjhopman@chromium.org changed reviewers:
+ zea@chromium.org

[cjhopman, 2014-10-10 16:33:47]

On 2014/10/10 11:12:21, jochen wrote:
> do you actually want me to do an indepth review, or just rubberstamp brett's
> review?

jochen: rubberstamp is probably fine... the components/ stuff is all pretty
trivial
ben: sorry bout that, ptal at chrome/ and the trivial changes in device/usb,
printing/, third_party/libusb
zea: for OWNERS of sync/ (these changes are also rather trivial).

[Nicolas Zea, 2014-10-10 23:45:57]

rubberstamp sync LGTM

[jochen (gone - plz use gerrit), 2014-10-13 08:13:29]

//components lgtm

[cjhopman, 2014-10-13 18:39:15]

cjhopman@chromium.org changed reviewers:
+ nyquist@chromium.org

[cjhopman, 2014-10-13 18:39:17]

nyquist: for chrome/android OWNERS
ben: TBRed for changes in chrome/ (but not c/android) device/usb,
printing/, third_party/libusb

[nyquist, 2014-10-13 20:49:51]

chrome/android lgtm

[cjhopman, 2014-10-13 20:57:38]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-10-13 20:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/570203002/590001

[commit-bot: I haz the power, 2014-10-13 21:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:07:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cjhopman, 2014-10-13 22:02:30]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-10-13 22:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/570203002/590001

[commit-bot: I haz the power, 2014-10-13 22:48:04]

Committed patchset #9 (id:590001)

[commit-bot: I haz the power, 2014-10-13 22:48:48]

Patchset 9 (id:??) landed as
https://crrev.com/11a68cbf1df1110ebac0b649edf2aef22682387e
Cr-Commit-Position: refs/heads/master@{#299381}