Instead of special casing one-element interpolations, just generate a static call to _interpolateSi…

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
@@ skipping 2868 matching lines @@
 const Function& StringInterpolateInstr::CallFunction() const {
   if (function_.IsNull()) {
     const int kNumberOfArguments = 1;
     const Array& kNoArgumentNames = Object::null_array();
     const Class& cls =
         Class::Handle(Library::LookupCoreClass(Symbols::StringBase()));
     ASSERT(!cls.IsNull());
     function_ =
         Resolver::ResolveStatic(
             cls,
-            is_singleton_
-                ? Library::PrivateCoreLibName(Symbols::InterpolateSingle())
-                : Library::PrivateCoreLibName(Symbols::Interpolate()),
+            Library::PrivateCoreLibName(Symbols::Interpolate()),
             kNumberOfArguments,
             kNoArgumentNames);
   }
   ASSERT(!function_.IsNull());
   return function_;
 }
 
 
 // Replace StringInterpolateInstr with a constant string if all inputs are
 // constant of [string, number, boolean, null].
 // Leave the CreateArrayInstr and StoreIndexedInstr in the stream in case
 // deoptimization occurs.
 Definition* StringInterpolateInstr::Canonicalize(FlowGraph* flow_graph) {
   // The following graph structure is generated by the graph builder:
   //   v2 <- CreateArray(v0)
   //   StoreIndexed(v2, v3, v4)   -- v3:constant index, v4: value.
   //   ..
   //   v8 <- StringInterpolate(v2)
-  // or for a single element:
-  //   v2 <- StringInterpolateSingle(v0)
 
   // Don't compile-time fold when optimizing the interpolation function itself.
   if (flow_graph->parsed_function().function().raw() == CallFunction().raw()) {
     return this;
   }
 
-  if (is_singleton_) {
-    Value* value = this->value();
-    if (!value->definition()->IsConstant()) return this;
-    const Object& obj = value->definition()->AsConstant()->value();
-    if (!obj.IsNumber() && !obj.IsString() && !obj.IsBool() && !obj.IsNull()) {
-      return this;
-    }
-    // This is only really useful for numbers, so we don't bother optimizing
-    // for strings, bool or null.
-    const Array& interpolate_arg = Array::Handle(Array::New(1));
-    interpolate_arg.SetAt(0, obj);
-    const Object& result = Object::Handle(
-        DartEntry::InvokeFunction(CallFunction(), interpolate_arg));
-    if (result.IsUnhandledException()) {
-      return this;
-    }
-    ASSERT(result.IsString());
-    const String& converted =
-        String::ZoneHandle(Symbols::New(String::Cast(result)));
-    return flow_graph->GetConstant(converted);
-  }
   CreateArrayInstr* create_array = value()->definition()->AsCreateArray();
   ASSERT(create_array != NULL);
   // Check if the string interpolation has only constant inputs.
   Value* num_elements = create_array->num_elements();
   if (!num_elements->BindsToConstant() ||
       !num_elements->BoundConstant().IsSmi()) {
     return this;
   }
   intptr_t length = Smi::Cast(num_elements->BoundConstant()).Value();
   GrowableArray<ConstantInstr*> constants(length);
@@ skipping 195 matching lines @@
     case Token::kTRUNCDIV: return 0;
     case Token::kMOD: return 1;
     default: UNIMPLEMENTED(); return -1;
   }
 }
 
 
 #undef __
 
 }  // namespace dart