Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 57013002: chromium-status: tighten up the Who/When columns (Closed)

Created:
7 years, 1 month ago by vapier
Modified:
7 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews
Visibility:
Public.

Description

chromium-status: tighten up the Who/When columns Often times the Message field is very long (especially when multiple failures are logged in there). This forces the other two columns to get wrapped heavily. For the date, this makes the field unreadable: Sat Nov 02, 17:09 UTC Shrink the size slightly for both these fields (as we just want to scan them vertically, but otherwise focus on the Message), disable white space breaking on the date, and move the redundant timezone to the column header. TEST=ran an appengine instance and checked the output

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M trunk/tools/chromium-status/stylesheets/style.css View 1 chunk +9 lines, -0 lines 0 comments Download
M trunk/tools/chromium-status/templates/main.html View 1 chunk +4 lines, -4 lines 4 comments Download

Messages

Total messages: 6 (0 generated)
vapier
7 years, 1 month ago (2013-11-02 18:06:31 UTC) #1
cmp
lgtm with comment https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html File trunk/tools/chromium-status/templates/main.html (right): https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html#newcode29 trunk/tools/chromium-status/templates/main.html:29: <td><b>When (UTC)</b></td> We want this to ...
7 years, 1 month ago (2013-11-02 22:46:54 UTC) #2
vapier
https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html File trunk/tools/chromium-status/templates/main.html (right): https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html#newcode29 trunk/tools/chromium-status/templates/main.html:29: <td><b>When (UTC)</b></td> yeah, i agree with that entirely. i've ...
7 years, 1 month ago (2013-11-02 22:48:36 UTC) #3
vapier
https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html File trunk/tools/chromium-status/templates/main.html (right): https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html#newcode29 trunk/tools/chromium-status/templates/main.html:29: <td><b>When (UTC)</b></td> in looking at docs online, i don't ...
7 years, 1 month ago (2013-11-03 18:17:16 UTC) #4
cmp
https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html File trunk/tools/chromium-status/templates/main.html (right): https://codereview.chromium.org/57013002/diff/1/trunk/tools/chromium-status/templates/main.html#newcode29 trunk/tools/chromium-status/templates/main.html:29: <td><b>When (UTC)</b></td> On 2013/11/03 18:17:16, vapier wrote: > in ...
7 years, 1 month ago (2013-11-03 19:34:50 UTC) #5
vapier
7 years, 1 month ago (2013-11-04 22:40:31 UTC) #6
moved to https://codereview.chromium.org/57643007/ so i can get it through the
CQ (with a fixed base url)

Powered by Google App Engine
This is Rietveld 408576698