Issue 570073002: Revert of Remove deprecated extension notification from ProcessManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 570073002: Revert of Remove deprecated extension notification from ProcessManager. (Closed)

Created:
6 years, 3 months ago by Alexander Potapenko

Modified:
6 years, 3 months ago

Reviewers:
Bernhard Bauer, Ken Rockot(use gerrit already), limasdf, Jitu( very slow this week)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Remove deprecated extension notification from ProcessManager. (patchset #2 id:20001 of https://codereview.chromium.org/566863002/) Reason for revert: One of the tests crashes with a UAF: http://crbug.com/414245 Original issue's description: > Remove deprecated extension notification from ProcessManager. > > This patch used EntensionRegistryObserver instead of DEPRECATED extension > NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED removed now. > > BUG=411568 > > Committed: https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763 > Cr-Commit-Position: refs/heads/master@{#294799} TBR=bauerb@chromium.org,rockot@chromium.org,limasdf@gmail.com,jitendra.ks@samsung.com NOTREECHECKS=true NOTRY=true BUG=411568 Committed: https://crrev.com/34cdb3e534fc53c9d0ad5b4e9754e6a0710bd905 Cr-Commit-Position: refs/heads/master@{#294806}

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -40 lines)			Patch
M	extensions/browser/process_manager.h	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	extensions/browser/process_manager.cc	View	4 chunks	+33 lines, -27 lines	0 comments	Download
M	extensions/browser/process_manager_unittest.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Alexander Potapenko

Created Revert of Remove deprecated extension notification from ProcessManager.

6 years, 3 months ago (2014-09-15 12:03:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570073002/1

6 years, 3 months ago (2014-09-15 12:04:20 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 82683591140124ad824bae58975b2ae4cd512217

6 years, 3 months ago (2014-09-15 12:10:29 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 12:24:25 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/34cdb3e534fc53c9d0ad5b4e9754e6a0710bd905
Cr-Commit-Position: refs/heads/master@{#294806}