Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 570053002: Revert "Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*." (Closed)

Created:
6 years, 3 months ago by ygorshenin1
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*." This reverts commit 40979bf265c3ffbe1736a87935418da72be5d1f1. BUG=398856 Committed: https://chromium.googlesource.com/chromium/src/+/478969cdb55bccc3d76b2e93803737a9de8847e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -1112 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service.h View 4 chunks +64 lines, -31 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service.cc View 12 chunks +261 lines, -70 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 1 chunk +0 lines, -76 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_factory.h View 4 chunks +13 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/ownership/owner_settings_service_factory.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 5 chunks +45 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.cc View 5 chunks +12 lines, -100 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M components/ownership.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M components/ownership/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M components/ownership/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/ownership/owner_settings_service.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/ownership/owner_settings_service.cc View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/478969cdb55bccc3d76b2e93803737a9de8847e9 Cr-Commit-Position: refs/heads/master@{#294794}
6 years, 3 months ago (2014-09-15 09:30:08 UTC) #1
ygorshenin1
6 years, 3 months ago (2014-09-15 09:31:04 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 478969c.

Powered by Google App Engine
This is Rietveld 408576698