Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 570033002: Fix handling of resources (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
brettw, newt (away)
CC:
chromium-reviews, darin-cc_chromium.org, klundberg+watch_chromium.org, jam, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-openmax-dl
Project:
chromium
Visibility:
Public.

Description

Fix handling of resources This has several changes: apks no longer export information about resources (this means to get resources, a target must depend on the android_resources target). libraries are only built against their direct resource dependencies. If a library refers directly to some resource id, it should depend directly on the corresponding android_resources target. When building an apk, we now properly create the R.java files for all the packages of all the apk's resource dependencies. Since an apk will always have a resources srcjar, it will always have java code (so remove the no-java path). BUG=359249 Committed: https://crrev.com/fed93a9b98c45ad7b0c8d3e3b0b9805d5a5107ac Cr-Commit-Position: refs/heads/master@{#295362}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -54 lines) Patch
M build/android/gyp/process_resources.py View 3 chunks +4 lines, -8 lines 0 comments Download
M build/android/gyp/write_build_config.py View 3 chunks +21 lines, -4 lines 1 comment Download
M build/config/android/internal_rules.gni View 1 3 chunks +15 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 7 chunks +23 lines, -42 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
cjhopman
newt: *
6 years, 3 months ago (2014-09-15 01:55:29 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/570033002/diff/20001/build/android/gyp/write_build_config.py File build/android/gyp/write_build_config.py (right): https://codereview.chromium.org/570033002/diff/20001/build/android/gyp/write_build_config.py#newcode170 build/android/gyp/write_build_config.py:170: if options.type == 'android_resources' or options.type == 'android_apk': ...
6 years, 3 months ago (2014-09-15 18:44:25 UTC) #3
cjhopman
brettw: for OWNERS (content/ and build/config/)
6 years, 3 months ago (2014-09-17 21:18:36 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-17 21:19:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570033002/20001
6 years, 3 months ago (2014-09-17 21:26:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ba731c0592c16887e689f531c0e78405c86577cb
6 years, 3 months ago (2014-09-17 22:33:55 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 22:34:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fed93a9b98c45ad7b0c8d3e3b0b9805d5a5107ac
Cr-Commit-Position: refs/heads/master@{#295362}

Powered by Google App Engine
This is Rietveld 408576698