Move screenColorProfile from Platform to ImageDecoder

Source/platform/image-decoders/ImageDecoder.h

Index: Source/platform/image-decoders/ImageDecoder.h
diff --git a/Source/platform/image-decoders/ImageDecoder.h b/Source/platform/image-decoders/ImageDecoder.h
index 4f5d4f9a401d29af91609c6444e6c25373510a31..0a3a1ebfde4519eae8a2bec9dafd09d17ed1c9d2 100644
--- a/Source/platform/image-decoders/ImageDecoder.h
+++ b/Source/platform/image-decoders/ImageDecoder.h
@@ -43,6 +43,8 @@
 #include "qcms.h"
 #endif
 
+typedef Vector<char> ColorProfile;

[Mike West, 2014/09/15 07:12:16]

It looks this type is only used in the OutputDeviceProfile class, is that the
case? If so, you might consider scoping the typedef to that class.

[Noel Gordon, 2014/09/15 07:27:17]

Yeah, it's needed in (JPEG|PNG|WEBP)ImageDecoder files also.

+
 namespace blink {
 
 // ImagePlanes can be used to decode color components into provided buffers instead of using an ImageFrame.
@@ -196,16 +198,15 @@ public:
         OutputDeviceProfile()
             : m_outputDeviceProfile(0)
         {
-            // FIXME: Add optional ICCv4 support.
-            // FIXME: add support for multiple monitors.
-            ColorProfile profile;
-            screenColorProfile(profile);
+            ColorProfile profile = screenColorProfile();
             if (!profile.isEmpty())
                 m_outputDeviceProfile = qcms_profile_from_memory(profile.data(), profile.size());
+
             if (m_outputDeviceProfile && qcms_profile_is_bogus(m_outputDeviceProfile)) {
                 qcms_profile_release(m_outputDeviceProfile);
                 m_outputDeviceProfile = 0;
             }
+
             if (!m_outputDeviceProfile)
                 m_outputDeviceProfile = qcms_profile_sRGB();
             if (m_outputDeviceProfile)
@@ -215,6 +216,17 @@ public:
         qcms_profile* profile() const { return m_outputDeviceProfile; }
 
     private:
+        static ColorProfile screenColorProfile()
+        {
+            // FIXME: Add optional ICCv4 support and support for multiple monitors.

[Mike West, 2014/09/15 07:12:16]

Nit: Is there a bug filed for this FIXME? It'd be nice to link to it if there is
one.

[Noel Gordon, 2014/09/15 07:27:17]

https://crbug.com/353818 and I know the bug well.  I might link to it in a
future CL, or I might just remove this code once it's fixed.

+            WebVector<char> profile;
+            Platform::current()->screenColorProfile(&profile);
+
+            ColorProfile colorProfile;
+            colorProfile.append(profile.data(), profile.size());

[jochen (gone - plz use gerrit), 2014/09/15 12:46:02]

Why not just use the WebVector<>? You now copy the data twice.

[Noel Gordon, 2014/09/15 12:55:53]

The data was copied twice before this change (refer to PlatformScreen.cpp),
unless I'm misunderstadning you.

+            return colorProfile;
+        }
+
         qcms_profile* m_outputDeviceProfile;
     };