Issue 57001: Patch for bug 8454

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57001: Patch for bug 8454 (Closed)

Created:
11 years, 9 months ago by Paul Robinson

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, glen, xji, arv (Not doing code reviews), jeremy

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Patch for bug 8454. Webkit uses the 'alt' attribute on an <img> tag as the title in drag&drop situations. This patch adds the alt tag to the imgs on the new_tab html page. Perhaps an extended solution to this problem would be to lookup the title for link imgs without an 'alt' tag in the history_database. That is not necessary to fix this bug though. BUG=8454

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/new_tab.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

Sorry for no-one paying attention to this CL. Your change looks good and we'll patch ...

11 years, 7 months ago (2009-05-16 22:11:14 UTC) #1

jeremy

LGTM I'm assuming I'm on the review list for RTL concerns. May want to add ...

11 years, 7 months ago (2009-05-18 18:27:46 UTC) #3

xji

11 years, 7 months ago (2009-05-18 20:54:48 UTC) #5

> May want to add a note to http://crbug.com/5996 since I think that may affect
> this feature.

Hi Jeremy,

I do not understand why these 2 are related.
Could you elaborate a bit?

Thanks,
Xiaomei

P.S. did any of you got an email for the review? I do not think I got the review
email. So, I saw this change list in the review page, but I thought it is not
ready for review yet.

Expand Messages | Collapse Messages