Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 57001: Patch for bug 8454 (Closed)

Created:
11 years, 9 months ago by Paul Robinson
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch for bug 8454. Webkit uses the 'alt' attribute on an <img> tag as the title in drag&drop situations. This patch adds the alt tag to the imgs on the new_tab html page. Perhaps an extended solution to this problem would be to lookup the title for link imgs without an 'alt' tag in the history_database. That is not necessary to fix this bug though. BUG=8454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/new_tab.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Glen Murphy
Sorry for no-one paying attention to this CL. Your change looks good and we'll patch ...
11 years, 7 months ago (2009-05-16 22:11:14 UTC) #1
arv (Not doing code reviews)
LGTM
11 years, 7 months ago (2009-05-18 17:44:06 UTC) #2
jeremy
LGTM I'm assuming I'm on the review list for RTL concerns. May want to add ...
11 years, 7 months ago (2009-05-18 18:27:46 UTC) #3
xji
LGTM
11 years, 7 months ago (2009-05-18 20:49:39 UTC) #4
xji
11 years, 7 months ago (2009-05-18 20:54:48 UTC) #5
> May want to add a note to http://crbug.com/5996 since I think that may affect
> this feature.

Hi Jeremy,

I do not understand why these 2 are related.
Could you elaborate a bit?

Thanks,
Xiaomei

P.S. did any of you got an email for the review? I do not think I got the review
email. So, I saw this change list in the review page, but I thought it is not
ready for review yet.

Powered by Google App Engine
This is Rietveld 408576698