content/common/gpu/client/gl_helper_readback_support.cc - Issue 570003002: [Aura] Use GLHelper support to validate format before processing texture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper_readback_support.cc

Issue 570003002: [Aura] Use GLHelper support to validate format before processing texture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding TODO Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/gl_helper_readback_support.cc

diff --git a/content/common/gpu/client/gl_helper_readback_support.cc b/content/common/gpu/client/gl_helper_readback_support.cc

index 4412c9546dece7a44a74d070574a6f082ef7b8d0..9c1a4ce8ca22767e08cfff1eab2ff7451490be26 100644

--- a/content/common/gpu/client/gl_helper_readback_support.cc

+++ b/content/common/gpu/client/gl_helper_readback_support.cc

@@ -25,6 +25,8 @@ void GLHelperReadbackSupport::InitializeReadbackSupport() {

for (int i = 0; i <= kLastEnum_SkColorType; ++i) {

format_support_table_[i] = GLHelperReadbackSupport::NOT_SUPPORTED;

}

+ // TODO(sikugu): kAlpha_8_SkColorType support check is failing on mesa.

+ // See crbug.com/415667.

CheckForReadbackSupport(kRGB_565_SkColorType);

CheckForReadbackSupport(kARGB_4444_SkColorType);

CheckForReadbackSupport(kRGBA_8888_SkColorType);

« no previous file with comments | « content/browser/compositor/delegated_frame_host.cc ('k') | no next file » | no next file with comments »