<label> should support form association by parser

As per spec and to be consistent with other browsers (Firefox & IE11), we should support form association by parser. 

BUG=336723
TEST=fast/dom/HTMLLabelElement/label-formAssociatedElement.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182217

[spartha, 2014-09-15 20:14:12]

Patchset #2 (id:20001) has been deleted

[spartha, 2014-09-15 20:22:36]

sudarshan.p@samsung.com changed reviewers:
+ keishi@chromium.org, tkent@chromium.org

[spartha, 2014-09-15 20:25:26]

I did not get why <label> was not a FormAssociatedElement in the first place.
This patch makes HTMLLabelElement a sub class of FormAssociatedElement. Please
let me know if this approach is fine.

[keishi, 2014-09-16 01:59:19]

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
File Source/core/html/HTMLLabelElement.cpp (right):

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.cpp:82: return
!fastGetAttribute(formAttr).isNull() ?
FormAssociatedElement::findAssociatedForm(this) : FormAssociatedElement::form();
I think we shouldn't need to use findAssociatedForm if we call
formAttributeChanged from parseAttribute.

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.cpp:207:
scope.removeLabel(oldForAttributeValue, toHTMLLabelElement(label));
I think we don't need to use toHTMLLabelElement and just use "this".

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
File Source/core/html/HTMLLabelElement.h (right):

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.h:34: DEFINE_WRAPPERTYPEINFO();
FormAssociatedElement is GarbageCollectedMixin so we need to add
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLLabelElement)

[spartha, 2014-09-17 11:02:18]

Thanks for review. Patch updated, PTAL!

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
File Source/core/html/HTMLLabelElement.cpp (right):

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.cpp:82: return
!fastGetAttribute(formAttr).isNull() ?
FormAssociatedElement::findAssociatedForm(this) : FormAssociatedElement::form();
On 2014/09/16 01:59:19, keishi wrote:
> I think we shouldn't need to use findAssociatedForm if we call
> formAttributeChanged from parseAttribute.

Done.

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.cpp:207:
scope.removeLabel(oldForAttributeValue, toHTMLLabelElement(label));
On 2014/09/16 01:59:19, keishi wrote:
> I think we don't need to use toHTMLLabelElement and just use "this".

Done.

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
File Source/core/html/HTMLLabelElement.h (right):

https://codereview.chromium.org/569993002/diff/40001/Source/core/html/HTMLLab...
Source/core/html/HTMLLabelElement.h:34: DEFINE_WRAPPERTYPEINFO();
On 2014/09/16 01:59:19, keishi wrote:
> FormAssociatedElement is GarbageCollectedMixin so we need to add
> WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLLabelElement)

Done.

[keishi, 2014-09-18 02:30:44]

lgtm

[spartha, 2014-09-18 02:43:56]

The CQ bit was checked by sudarshan.p@samsung.com

[commit-bot: I haz the power, 2014-09-18 02:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569993002/80001

[commit-bot: I haz the power, 2014-09-18 03:52:54]

Committed patchset #4 (id:80001) as 182217