Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 569953002: util_test MachMessageServer.ReturnCodeNoReply: keep the child alive until the server is done (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

util_test MachMessageServer.ReturnCodeNoReply: keep the child alive until the server is done handling its request. In most tests, this is handled automatically because the client expects a reply from the server, and waits for this reply. This test is different because the server does handle the message, but does not send a reply, so the client does not wait for one. When the child process exits before the parent has had a chance to inspect the message it received, the parent will find a dead name where it expects the remote port to be, causing this test to be flaky based on the outcome of this race. The potential for a similar race existed in the MachMessageServer.ComplexNotDestroyedNoReply test because it also involved a request without a reply. In that test, the situation was handled by not allowing the child to exit until signaled to do so by the parent. The same logic should be used for both no-reply tests. TEST=util_test MachMessageServer.ReturnCodeNoReply R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b77c788543a1b6e8c6862ac8af35948d03ea1eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M util/mach/mach_message_server_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-14 05:03:29 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-15 18:19:38 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-15 19:08:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b77c788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698