Make content_shell_apk build completely

build/config/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/allocator.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 
 declare_args() {
@@ skipping 18 matching lines @@
 # For now we define these globally to match the current GYP build.
 config("feature_flags") {
   # TODO(brettw) most of these need to be parameterized.
   defines = [
       "CHROMIUM_BUILD",
       "ENABLE_EGLIMAGE=1",
       "ENABLE_BACKGROUND=1",
       "V8_DEPRECATION_WARNINGS",  # Don't use deprecated V8 APIs anywhere.
   ]
 
+  if (enable_notifications) {
+    defines += [ "ENABLE_NOTIFICATIONS" ]
+  }
+
   if (cld_version > 0) {
     defines += [ "CLD_VERSION=$cld_version" ]
   }
   if (enable_mdns) {
     defines += [ "ENABLE_MDNS=1" ]
   }
   if (enable_notifications) {

[brettw, 2014/09/20 05:47:36]

Isn't this the thing you added above?

[cjhopman, 2014/09/22 18:43:52]

Yep, looks like jamesr landed that bit before me.

     defines += [ "ENABLE_NOTIFICATIONS" ]
   }
   if (enable_pepper_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_PEPPER_CDMS" ]
   }
   if (enable_browser_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_BROWSER_CDMS" ]
   }
@@ skipping 232 matching lines @@
       "CoreText.framework",
       "Foundation.framework",
       "UIKit.framework",
     ]
   } else if (is_linux) {
     libs = [
       "dl",
     ]
   }
 }