Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

Issue 569913002: fix virtual_test_suites() for browser_test ports (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
index f357e8db715bc2caaeee0faf6cb6edd759dfb4f6..b37157e8d1d8882e27a0ea42cbcb35f99d2d5580 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
@@ -29,6 +29,7 @@
import unittest
from webkitpy.common.system.executive_mock import MockExecutive2
+from webkitpy.common.system.systemhost import SystemHost
from webkitpy.common.system.systemhost_mock import MockSystemHost
from webkitpy.tool.mocktool import MockOptions
@@ -85,6 +86,11 @@ class BrowserTestWinTest(port_testcase.PortTestCase):
self.assertEqual(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(), 20000)
self.assertEqual(self.make_port(options=MockOptions(configuration='Debug')).default_timeout_ms(), 60000)
+ def test_virtual_test_suites(self):
+ # We override this test to ensure that we're passing a full port name (and hence can run
+ # the test on all platforms).
+ port = self.make_port(host=SystemHost(), port_name='win-win7')
+
class BrowserTestMacTest(port_testcase.PortTestCase):
os_name = 'mac'

Powered by Google App Engine
This is Rietveld 408576698