Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py

Issue 569913002: fix virtual_test_suites() for browser_test ports (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rework implementation of test_virtual_test_suites(), browser_test_unittest Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 20 matching lines...) Expand all
31 from webkitpy.common.system import executive_mock 31 from webkitpy.common.system import executive_mock
32 from webkitpy.common.system.systemhost_mock import MockSystemHost 32 from webkitpy.common.system.systemhost_mock import MockSystemHost
33 from webkitpy.tool.mocktool import MockOptions 33 from webkitpy.tool.mocktool import MockOptions
34 34
35 from webkitpy.layout_tests.port import linux 35 from webkitpy.layout_tests.port import linux
36 from webkitpy.layout_tests.port import port_testcase 36 from webkitpy.layout_tests.port import port_testcase
37 37
38 38
39 class LinuxPortTest(port_testcase.PortTestCase): 39 class LinuxPortTest(port_testcase.PortTestCase):
40 port_name = 'linux' 40 port_name = 'linux'
41 full_port_name = 'linux-x86'
41 port_maker = linux.LinuxPort 42 port_maker = linux.LinuxPort
42 43
43 def assert_architecture(self, port_name=None, file_output=None, expected_arc hitecture=None): 44 def assert_architecture(self, port_name=None, file_output=None, expected_arc hitecture=None):
44 host = MockSystemHost() 45 host = MockSystemHost()
45 host.filesystem.isfile = lambda x: 'content_shell' in x 46 host.filesystem.isfile = lambda x: 'content_shell' in x
46 if file_output: 47 if file_output:
47 host.executive = executive_mock.MockExecutive2(file_output) 48 host.executive = executive_mock.MockExecutive2(file_output)
48 49
49 port = self.make_port(host, port_name=port_name) 50 port = self.make_port(host, port_name=port_name)
50 self.assertEqual(port.architecture(), expected_architecture) 51 self.assertEqual(port.architecture(), expected_architecture)
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 # Test that optional relative paths are returned unmodified. 99 # Test that optional relative paths are returned unmodified.
99 options = MockOptions(configuration='Release', build_directory='foo') 100 options = MockOptions(configuration='Release', build_directory='foo')
100 self.assert_build_path(options, ['/mock-checkout/out/Release'], 'foo/Rel ease') 101 self.assert_build_path(options, ['/mock-checkout/out/Release'], 'foo/Rel ease')
101 102
102 def test_driver_name_option(self): 103 def test_driver_name_option(self):
103 self.assertTrue(self.make_port()._path_to_driver().endswith('content_she ll')) 104 self.assertTrue(self.make_port()._path_to_driver().endswith('content_she ll'))
104 self.assertTrue(self.make_port(options=MockOptions(driver_name='OtherDri ver'))._path_to_driver().endswith('OtherDriver')) 105 self.assertTrue(self.make_port(options=MockOptions(driver_name='OtherDri ver'))._path_to_driver().endswith('OtherDriver'))
105 106
106 def test_path_to_image_diff(self): 107 def test_path_to_image_diff(self):
107 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout /out/Release/image_diff') 108 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout /out/Release/image_diff')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698