fix virtual_test_suites() for browser_test ports

Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py

 # Copyright (C) 2014 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #    * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #    * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 20 matching lines @@
 from webkitpy.common.system.executive_mock import MockExecutive2
 from webkitpy.common.system.systemhost_mock import MockSystemHost
 from webkitpy.tool.mocktool import MockOptions
 
 from webkitpy.layout_tests.models import test_run_results
 from webkitpy.layout_tests.port import browser_test
 from webkitpy.layout_tests.port import port_testcase
 from webkitpy.layout_tests.port import browser_test_driver
 
 
-class BrowserTestLinuxTest(port_testcase.PortTestCase):
-    port_name = 'linux'
-    port_maker = browser_test.BrowserTestLinuxPort
-
-    def test_driver_name_option(self):
-        self.assertTrue(self.make_port(options=MockOptions(driver_name='browser_tests'))._path_to_driver().endswith('browser_tests'))
-
-    def test_layout_tests_dir(self):
-        self.assertTrue(self.make_port().layout_tests_dir().endswith('chrome/test/data/printing/layout_tests'))
-
-    def test_driver_type(self):
-        self.assertTrue(isinstance(self.make_port(options=MockOptions(driver_name='browser_tests')).create_driver(1), browser_test_driver.BrowserTestDriver))
+class _BrowserTestTestCaseMixin(object):
 
     def test_check_sys_deps(self):
         port = self.make_port()
         port._executive = MockExecutive2(exit_code=0)
         self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results.OK_EXIT_STATUS)
 
+    def test_driver_name_option(self):
+        self.assertTrue(self.make_port()._path_to_driver().endswith(self.driver_name_endswith))
+
     def test_default_timeout_ms(self):
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(), 10000)
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Debug')).default_timeout_ms(), 30000)
+        self.assertEqual(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(),
+                         self.timeout_ms)
+        self.assertEqual(self.make_port(options=MockOptions(configuration='Debug')).default_timeout_ms(),
+                         3 * self.timeout_ms)
+
+    def test_driver_type(self):
+        self.assertTrue(isinstance(self.make_port(options=MockOptions(driver_name='browser_tests')).create_driver(1), browser_test_driver.BrowserTestDriver))
+
+    def test_layout_tests_dir(self):
+        self.assertTrue(self.make_port().layout_tests_dir().endswith('chrome/test/data/printing/layout_tests'))
+
+    def test_virtual_test_suites(self):
+        # The browser_tests port do not use virtual test suites, so we are just testing the stub.
+        port = self.make_port()
+        self.assertEqual(port.virtual_test_suites(), [])
 
 
-class BrowserTestWinTest(port_testcase.PortTestCase):
+class BrowserTestLinuxTest(_BrowserTestTestCaseMixin, port_testcase.PortTestCase):
+    port_name = 'linux'
+    port_maker = browser_test.BrowserTestLinuxPort
+    driver_name_endswith = 'browser_tests'
+    timeout_ms = 10 * 1000
+
+
+class BrowserTestWinTest(_BrowserTestTestCaseMixin, port_testcase.PortTestCase):
     port_name = 'win'
     port_maker = browser_test.BrowserTestWinPort
     os_name = 'win'
     os_version = 'xp'
-
-    def test_driver_name_option(self):
-        self.assertTrue(self.make_port(options=MockOptions(driver_name='browser_tests'))._path_to_driver().endswith('browser_tests.exe'))
-
-    def test_layout_tests_dir(self):
-        self.assertTrue(self.make_port().layout_tests_dir().endswith('chrome/test/data/printing/layout_tests'))
-
-    def test_driver_type(self):
-        self.assertTrue(isinstance(self.make_port(options=MockOptions(driver_name='browser_tests')).create_driver(1), browser_test_driver.BrowserTestDriver))
-
-    def test_check_sys_deps(self):
-        port = self.make_port()
-        port._executive = MockExecutive2(exit_code=0)
-        self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results.OK_EXIT_STATUS)
-
-    def test_default_timeout_ms(self):
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(), 20000)
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Debug')).default_timeout_ms(), 60000)
+    driver_name_endswith = 'browser_tests.exe'
+    timeout_ms = 20 * 1000
 
 
-class BrowserTestMacTest(port_testcase.PortTestCase):
+class BrowserTestMacTest(_BrowserTestTestCaseMixin, port_testcase.PortTestCase):
     os_name = 'mac'
     os_version = 'snowleopard'
     port_name = 'mac'
     port_maker = browser_test.BrowserTestMacPort
-
-    def test_driver_name_option(self):
-        self.assertTrue(self.make_port(options=MockOptions(driver_name='browser_tests'))._path_to_driver().endswith('browser_tests'))
-
-    def test_layout_tests_dir(self):
-        self.assertTrue(self.make_port().layout_tests_dir().endswith('chrome/test/data/printing/layout_tests'))
-
-    def test_driver_type(self):
-        self.assertTrue(isinstance(self.make_port(options=MockOptions(driver_name='browser_tests')).create_driver(1), browser_test_driver.BrowserTestDriver))
+    driver_name_endswith = 'browser_tests'
+    timeout_ms = 20 * 1000
 
     def test_driver_path(self):
         test_port = self.make_port(options=MockOptions(driver_name='browser_tests'))
         self.assertFalse('.app/Contents/MacOS' in test_port._path_to_driver())
-
-    def test_check_sys_deps(self):
-        port = self.make_port()
-        port._executive = MockExecutive2(exit_code=0)
-        self.assertEqual(port.check_sys_deps(needs_http=False), test_run_results.OK_EXIT_STATUS)
-
-    def test_default_timeout_ms(self):
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(), 20000)
-        self.assertEqual(self.make_port(options=MockOptions(configuration='Debug')).default_timeout_ms(), 60000)