Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: src/full-codegen.h

Issue 5699002: RFC: Switch to ast ids (instead of positions) for type feedback. (Closed)
Patch Set: Cleanup Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen.h
diff --git a/src/full-codegen.h b/src/full-codegen.h
index 8d9fe2d3322f7cd57f5c91395debf5cb965e342f..9b0769c6906a7a555e6a6f69f2e3aa465e0a6c7a 100644
--- a/src/full-codegen.h
+++ b/src/full-codegen.h
@@ -441,40 +441,41 @@ class FullCodeGenerator: public AstVisitor {
// Apply the compound assignment operator. Expects the left operand on top
// of the stack and the right one in the accumulator.
- void EmitBinaryOp(Token::Value op,
+ void EmitBinaryOp(BinaryOperation* expr,
+ Token::Value op,
OverwriteMode mode);
// Helper functions for generating inlined smi code for certain
// binary operations.
- void EmitInlineSmiBinaryOp(Expression* expr,
+ void EmitInlineSmiBinaryOp(BinaryOperation* expr,
Token::Value op,
OverwriteMode mode,
Expression* left,
Expression* right,
ConstantOperand constant);
- void EmitConstantSmiBinaryOp(Expression* expr,
+ void EmitConstantSmiBinaryOp(BinaryOperation* expr,
Token::Value op,
OverwriteMode mode,
bool left_is_constant_smi,
Smi* value);
- void EmitConstantSmiBitOp(Expression* expr,
+ void EmitConstantSmiBitOp(BinaryOperation* expr,
Token::Value op,
OverwriteMode mode,
Smi* value);
- void EmitConstantSmiShiftOp(Expression* expr,
+ void EmitConstantSmiShiftOp(BinaryOperation* expr,
Token::Value op,
OverwriteMode mode,
Smi* value);
- void EmitConstantSmiAdd(Expression* expr,
+ void EmitConstantSmiAdd(BinaryOperation* expr,
OverwriteMode mode,
bool left_is_constant_smi,
Smi* value);
- void EmitConstantSmiSub(Expression* expr,
+ void EmitConstantSmiSub(BinaryOperation* expr,
OverwriteMode mode,
bool left_is_constant_smi,
Smi* value);
@@ -531,7 +532,9 @@ class FullCodeGenerator: public AstVisitor {
static Register context_register();
// Helper for calling an IC stub.
- void EmitCallIC(Handle<Code> ic, RelocInfo::Mode mode);
+ void EmitCallIC(Handle<Code> ic,
+ RelocInfo::Mode mode,
+ AstId id = kNoAstId);
// Set fields in the stack frame. Offsets are the frame pointer relative
// offsets defined in, e.g., StandardFrameConstants.
@@ -551,7 +554,7 @@ class FullCodeGenerator: public AstVisitor {
void VisitForTypeofValue(Expression* expr);
struct BailoutEntry {
- unsigned id;
+ AstId id;
unsigned pc_and_state;
};

Powered by Google App Engine
This is Rietveld 408576698