Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 569863003: Re-activate touch selection after fling (Closed)

Created:
6 years, 3 months ago by mohsen
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-activate touch selection after fling Currently, when a scroll starts touch selection handles are hidden and then re-shown after scroll ends. But, if scroll ends in a fling, handles are not re-shown, because there hadn't been a way to determine end of the fling. Now that there is an IPC message notifying end of flings, we can re-show handles after a fling. BUG=413927 Committed: https://crrev.com/a8248c9e315b285492395fe1e3ce6f0b9cb816e6 Cr-Commit-Position: refs/heads/master@{#294927}

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -55 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 6 chunks +40 lines, -49 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 5 chunks +79 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mohsen
Please take a look...
6 years, 3 months ago (2014-09-15 18:01:53 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-15 19:41:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569863003/20001
6 years, 3 months ago (2014-09-15 22:04:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as eef36d80b758fcaf021f9e2f9a6a68a7e52c8565
6 years, 3 months ago (2014-09-15 23:44:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:48:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8248c9e315b285492395fe1e3ce6f0b9cb816e6
Cr-Commit-Position: refs/heads/master@{#294927}

Powered by Google App Engine
This is Rietveld 408576698