Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 56983002: Valgrind: retire suppression for bug 291240. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Valgrind: retire suppression for bug 291240. With underlying leak cause addressed, the suppression is no longer needed. R=thestig@chromium.org BUG=291240 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please have a look (the CL https://codereview.chromium.org/56973002/ addressing the underlying leak in the Blink v8 ...
7 years, 1 month ago (2013-11-02 16:36:12 UTC) #1
Lei Zhang
On 2013/11/02 16:36:12, sof wrote: > Please have a look (the CL https://codereview.chromium.org/56973002/ addressing > ...
7 years, 1 month ago (2013-11-02 17:00:49 UTC) #2
sof
On 2013/11/02 17:00:49, Lei Zhang wrote: > On 2013/11/02 16:36:12, sof wrote: > > Please ...
7 years, 1 month ago (2013-11-02 18:02:43 UTC) #3
Lei Zhang
lgtm - leak no longer shows up locally at ToT.
7 years, 1 month ago (2013-11-06 02:09:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/56983002/1
7 years, 1 month ago (2013-11-06 02:18:42 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 02:38:08 UTC) #6
Message was sent while issue was closed.
Change committed as 233195

Powered by Google App Engine
This is Rietveld 408576698