Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 569803004: Allow "url" to be an array of URL patterns (Closed)

Created:
6 years, 3 months ago by robwu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow "url" to be an array of URL patterns And also add error validation to the tabs.query method (while we're at it). BUG=128924 TEST=ExtensionApiTest.TabQuery Committed: https://crrev.com/f01542da87f0aa2b8bc69c9e26ea42181112b649 Cr-Commit-Position: refs/heads/master@{#295623}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update tabs.query documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +17 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/basics/query.js View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
robwu
6 years, 3 months ago (2014-09-15 23:08:43 UTC) #2
robwu
+yoz for review because Ben is OOO.
6 years, 3 months ago (2014-09-16 16:29:49 UTC) #4
Yoyo Zhou
https://codereview.chromium.org/569803004/diff/1/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://codereview.chromium.org/569803004/diff/1/chrome/common/extensions/api/tabs.json#newcode382 chrome/common/extensions/api/tabs.json:382: "description": "Match tabs against a <a href='match_patterns'>URL pattern</a>. Note ...
6 years, 3 months ago (2014-09-18 20:53:37 UTC) #5
robwu
https://codereview.chromium.org/569803004/diff/1/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://codereview.chromium.org/569803004/diff/1/chrome/common/extensions/api/tabs.json#newcode382 chrome/common/extensions/api/tabs.json:382: "description": "Match tabs against a <a href='match_patterns'>URL pattern</a>. Note ...
6 years, 3 months ago (2014-09-18 22:23:18 UTC) #6
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-18 22:24:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569803004/20001
6 years, 3 months ago (2014-09-18 23:02:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f6e2ce8ddc19615185543a728e13cc3fb832980a
6 years, 3 months ago (2014-09-19 00:32:24 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 00:33:22 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f01542da87f0aa2b8bc69c9e26ea42181112b649
Cr-Commit-Position: refs/heads/master@{#295623}

Powered by Google App Engine
This is Rietveld 408576698