Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 569793003: Remove unnecessary DCHECK in TouchEventQueue handler notification (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary DCHECK in TouchEventQueue handler notification Previously, the TouchEventQueue would flush itself when notified that all touch handlers have been removed. As that is no longer the case, remove the assert verifying that the queue is empty when notified that a touch handler has been added. BUG=406916 Committed: https://crrev.com/ce3cbf9560595152b9494ef51f109edd705abb04 Cr-Commit-Position: refs/heads/master@{#294711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
rbyers@: PTAL. I missed this when removing the flush logic (and noticed it after prompting ...
6 years, 3 months ago (2014-09-12 21:52:25 UTC) #2
Rick Byers
lgtm
6 years, 3 months ago (2014-09-12 23:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569793003/1
6 years, 3 months ago (2014-09-12 23:46:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 81cd3c110cfc031eecd3fc85a122b9bbca8bbafa
6 years, 3 months ago (2014-09-13 01:01:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 01:09:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce3cbf9560595152b9494ef51f109edd705abb04
Cr-Commit-Position: refs/heads/master@{#294711}

Powered by Google App Engine
This is Rietveld 408576698