Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 569793002: Cleanup: Remove a few unneeded #includes in Linux font files. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove a few unneeded #includes in Linux font files. Probably left over from code being moved around. Committed: https://crrev.com/edae4643b8120a56ce3f592495f5d712e9b24539 Cr-Commit-Position: refs/heads/master@{#294702}

Patch Set 1 #

Patch Set 2 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/browser/renderer_host/font_utils_linux.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
6 years, 3 months ago (2014-09-12 21:31:32 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-12 21:46:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569793002/1
6 years, 3 months ago (2014-09-12 21:48:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/66408) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13865) linux_chromium_gn_rel ...
6 years, 3 months ago (2014-09-12 22:17:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569793002/20001
6 years, 3 months ago (2014-09-12 23:00:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2e4e2094e2999bb73f7117e72c07563c9ae625df
6 years, 3 months ago (2014-09-13 00:32:28 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:47:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edae4643b8120a56ce3f592495f5d712e9b24539
Cr-Commit-Position: refs/heads/master@{#294702}

Powered by Google App Engine
This is Rietveld 408576698