Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 569743004: Clean up forward declarations in Source/core/rendering (Closed)

Created:
6 years, 3 months ago by zhaoze.zhou
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/rendering These forward references are not needed anymore. After this patch, Source/core/rendering has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182270

Patch Set 1 #

Patch Set 2 : undo to let gn build pass #

Patch Set 3 : tests #

Patch Set 4 : revert to fix gn #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/core/rendering/PaintInvalidationState.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
rwlbuis
On 2014/09/12 20:26:40, zhaoze.zhou wrote: > mailto:zhaoze.zhou@partner.samsung.com changed reviewers: > + mailto:rob.buis@samsung.com Great. But you ...
6 years, 3 months ago (2014-09-12 20:34:50 UTC) #2
zhaoze.zhou
On 2014/09/12 20:34:50, rwlbuis wrote: > On 2014/09/12 20:26:40, zhaoze.zhou wrote: > > mailto:zhaoze.zhou@partner.samsung.com changed ...
6 years, 3 months ago (2014-09-12 20:40:50 UTC) #3
pdr.
LGTM with a nit. I'm curious: what tool are you using to find these? https://codereview.chromium.org/569743004/diff/60001/Source/core/rendering/svg/SVGInlineTextBox.h ...
6 years, 3 months ago (2014-09-18 19:54:00 UTC) #6
zhaoze.zhou
https://codereview.chromium.org/569743004/diff/60001/Source/core/rendering/svg/SVGInlineTextBox.h File Source/core/rendering/svg/SVGInlineTextBox.h (right): https://codereview.chromium.org/569743004/diff/60001/Source/core/rendering/svg/SVGInlineTextBox.h#newcode31 Source/core/rendering/svg/SVGInlineTextBox.h:31: On 2014/09/18 19:54:00, pdr wrote: > Remove the extra ...
6 years, 3 months ago (2014-09-18 19:59:57 UTC) #7
zhaoze.zhou
On 2014/09/18 19:54:00, pdr wrote: > LGTM with a nit. > > > I'm curious: ...
6 years, 3 months ago (2014-09-18 20:00:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569743004/80001
6 years, 3 months ago (2014-09-18 20:01:28 UTC) #10
zhaoze.zhou
On 2014/09/18 19:54:00, pdr wrote: > LGTM with a nit. > > > I'm curious: ...
6 years, 3 months ago (2014-09-18 20:05:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:14:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 182270

Powered by Google App Engine
This is Rietveld 408576698