Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 569733002: cc: Remove cc:RasterRequiredForActivation synthetic delays. (Closed)

Created:
6 years, 3 months ago by ernstm
Modified:
6 years, 3 months ago
Reviewers:
reveman, brianderson, Sami
CC:
chromium-reviews, cc-bugs_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Remove cc:RasterRequiredForActivation synthetic delays. Remove cc:RasterRequiredForActivation synthetic delays from raster worker pools and disable pages that use it. R=reveman@chromium.org, skyostil@chromium.org, brianderson@chromium.org BUG= Committed: https://crrev.com/3a2f903115ed0149dba1646b6ec64e316c59a6ec Cr-Commit-Position: refs/heads/master@{#294710}

Patch Set 1 #

Patch Set 2 : Remove required_for_activation_count #

Total comments: 6

Patch Set 3 : post-increment to pre-increment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -125 lines) Patch
M cc/resources/gpu_raster_worker_pool.cc View 1 2 4 chunks +9 lines, -14 lines 0 comments Download
M cc/resources/image_copy_raster_worker_pool.cc View 1 2 5 chunks +9 lines, -14 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 1 2 4 chunks +9 lines, -14 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 6 chunks +2 lines, -58 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/rasterizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/rasterizer.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ernstm
PTAL
6 years, 3 months ago (2014-09-12 19:05:57 UTC) #1
reveman
lgtm with nits https://codereview.chromium.org/569733002/diff/20001/cc/resources/gpu_raster_worker_pool.cc File cc/resources/gpu_raster_worker_pool.cc (right): https://codereview.chromium.org/569733002/diff/20001/cc/resources/gpu_raster_worker_pool.cc#newcode97 cc/resources/gpu_raster_worker_pool.cc:97: required_for_activation_count++; nit: ++required_for_activation_count, pre-increment is preferred ...
6 years, 3 months ago (2014-09-12 20:06:34 UTC) #2
ernstm
https://codereview.chromium.org/569733002/diff/20001/cc/resources/gpu_raster_worker_pool.cc File cc/resources/gpu_raster_worker_pool.cc (right): https://codereview.chromium.org/569733002/diff/20001/cc/resources/gpu_raster_worker_pool.cc#newcode97 cc/resources/gpu_raster_worker_pool.cc:97: required_for_activation_count++; On 2014/09/12 20:06:33, reveman wrote: > nit: ++required_for_activation_count, ...
6 years, 3 months ago (2014-09-12 20:20:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569733002/40001
6 years, 3 months ago (2014-09-12 20:21:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/9091)
6 years, 3 months ago (2014-09-12 21:29:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569733002/40001
6 years, 3 months ago (2014-09-12 23:46:18 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 48bfef03d744ca8ad32bbd4a6d23ba67c4e12c75
6 years, 3 months ago (2014-09-13 01:00:32 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 01:03:05 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a2f903115ed0149dba1646b6ec64e316c59a6ec
Cr-Commit-Position: refs/heads/master@{#294710}

Powered by Google App Engine
This is Rietveld 408576698