pkg/analysis_server/lib/src/services/refactoring/inline_method.dart - Issue 569723004: Issue 19801. Fix for inlining referenced function with an expression body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

Issue 569723004: Issue 19801. Fix for inlining referenced function with an expression body. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/strings.dart ('k') | pkg/analysis_server/test/services/correction/strings_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

index 42316c207c214e0078cc03ee215013c303ec4905..cef48fbdbefd9a6cc5a42383bd87b092f03bb805 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

@@ -9,6 +9,7 @@ import 'dart:async';

import 'package:analysis_server/src/protocol.dart' hide Element;

import 'package:analysis_server/src/services/correction/source_range.dart';

import 'package:analysis_server/src/services/correction/status.dart';

+import 'package:analysis_server/src/services/correction/strings.dart';

import 'package:analysis_server/src/services/correction/util.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';

@@ -595,6 +596,7 @@ class _ReferenceProcessor {

source =

_refUtils.replaceSourceIndent(source, methodPrefix, _refPrefix);

source = source.trim();

+ source = removeEnd(source, ';');

}

// do insert

SourceRange range = rangeNode(_node);