Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 569683003: Only depend on NSS in one place. (Closed)

Created:
6 years, 3 months ago by davidben
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only depend on NSS in one place. Control with use_openssl, not with per-platform special-cases. BUG=416683 Committed: https://crrev.com/15d69d48ff5e91b7c6855f495ec2d2b2bed51f06 Cr-Commit-Position: refs/heads/master@{#297211}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : net_test_support #

Patch Set 4 : #

Patch Set 5 : Appease iOS again #

Total comments: 2

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -79 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 5 chunks +3 lines, -18 lines 0 comments Download
M net/net.gyp View 1 2 3 4 14 chunks +34 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
https://codereview.chromium.org/569683003/diff/80001/net/BUILD.gn File net/BUILD.gn (left): https://codereview.chromium.org/569683003/diff/80001/net/BUILD.gn#oldcode466 net/BUILD.gn:466: ] These and similar are redundant with the //crypto:platform ...
6 years, 3 months ago (2014-09-23 00:48:39 UTC) #2
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-09-26 21:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569683003/120001
6 years, 2 months ago (2014-09-29 18:08:10 UTC) #5
commit-bot: I haz the power
Committed patchset #7 (id:120001) as 05fdd103ddd9fbc798977edef782d7164db7d262
6 years, 2 months ago (2014-09-29 18:24:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:24:57 UTC) #7
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/15d69d48ff5e91b7c6855f495ec2d2b2bed51f06
Cr-Commit-Position: refs/heads/master@{#297211}

Powered by Google App Engine
This is Rietveld 408576698