Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 569683002: NaCl: Update revision in DEPS, r13733 -> r13739 (Closed)

Created:
6 years, 3 months ago by Derek Schuff
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Derek Schuff, David Yen, hidehiko, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13733 -> r13739 This pulls in the following Native Client changes: r13734: (dyen) Added support for extending basic thread functions in irt_ext. r13735: (dyen) Added testing for file link operations in irt_ext tests. r13738: (dschuff) Override xcode architecture for ia32 standalone builds r13739: (hidehiko) Non-SFI mode: Add -malign-double flag to pnacl-translate. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build Committed: https://crrev.com/4c1e40ba4cf297649a2b919644618c664d4812ce Cr-Commit-Position: refs/heads/master@{#294639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Derek Schuff
The mac nacl SDK buildbot is currently down, but before it went down it was ...
6 years, 3 months ago (2014-09-12 16:29:50 UTC) #2
bradn
lgtm
6 years, 3 months ago (2014-09-12 16:45:55 UTC) #4
bradn
This will be safe to land once this goes in: https://codereview.chromium.org/566963002/
6 years, 3 months ago (2014-09-12 17:18:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569683002/1
6 years, 3 months ago (2014-09-12 18:50:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b2c3564153af8de513acdf69c384f39bd23c5213
6 years, 3 months ago (2014-09-12 19:47:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:53:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c1e40ba4cf297649a2b919644618c664d4812ce
Cr-Commit-Position: refs/heads/master@{#294639}

Powered by Google App Engine
This is Rietveld 408576698