Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 569643003: Fix l10n_util DCHECK on OSX quitting with more than one download in progress. (Closed)

Created:
6 years, 3 months ago by mattm
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix l10n_util DCHECK on OSX quitting with more than one download in progress. BUG=none Committed: https://crrev.com/84f8c167438ff802727c5a0ca2d5b56f05bb2937 Cr-Commit-Position: refs/heads/master@{#294677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mattm
Was introduced way back in https://codereview.chromium.org/9969193/
6 years, 3 months ago (2014-09-12 20:16:17 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-12 20:59:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569643003/1
6 years, 3 months ago (2014-09-12 21:02:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f532cfd9fe27de515560c6e76a4fc5158be57154
6 years, 3 months ago (2014-09-12 22:09:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 22:12:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84f8c167438ff802727c5a0ca2d5b56f05bb2937
Cr-Commit-Position: refs/heads/master@{#294677}

Powered by Google App Engine
This is Rietveld 408576698