Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 569633002: Linux sandbox: fix MIPS Android compilation bug. (Closed)

Created:
6 years, 3 months ago by jln (very slow on Chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: fix MIPS Android compilation bug. third_party/lss includes headers that are broken on Android. Don't use LSS on Android and disable the corresponding test. BUG=413635 Committed: https://crrev.com/e8d33a8991a9dce25aae84225d462083d3ec29c1 Cr-Commit-Position: refs/heads/master@{#294607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jln (very slow on Chromium)
PTAL (and send to CQ if you're happy with it)!
6 years, 3 months ago (2014-09-12 15:57:38 UTC) #2
Michael van Ouwerkerk
Thanks Julien! lgtm
6 years, 3 months ago (2014-09-12 16:15:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569633002/1
6 years, 3 months ago (2014-09-12 16:16:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2fa44dbd6712f324ef5a6095521b97084263b950
6 years, 3 months ago (2014-09-12 17:04:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 17:09:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8d33a8991a9dce25aae84225d462083d3ec29c1
Cr-Commit-Position: refs/heads/master@{#294607}

Powered by Google App Engine
This is Rietveld 408576698